Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/ppdsc 2007 rolling back package.json version #157

Merged
merged 4 commits into from
Apr 11, 2022
Merged

Chore/ppdsc 2007 rolling back package.json version #157

merged 4 commits into from
Apr 11, 2022

Conversation

Vanals
Copy link
Contributor

@Vanals Vanals commented Apr 11, 2022 •
edited
Loading

PPDSC-2007

What

Rolling back to 5.4.0 in package JSON, so I can try again to release (5.4.1 HAS NOT been released to npm or to any environment)

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@Vanals Vanals changed the title Chore/ppdsc 2007 re rolling release Chore/ppdsc 2007 rolling pack package.json version Apr 11, 2022
@Vanals Vanals changed the base branch from develop to main April 11, 2022 11:03
@newskit-engineering
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2007-re-rolling-release
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2007-re-rolling-release/storybook

@Vanals Vanals added the ready for review Please assist in getting this reviewed label Apr 11, 2022
@Vanals Vanals changed the title Chore/ppdsc 2007 rolling pack package.json version Chore/ppdsc 2007 rolling back package.json version Apr 11, 2022
@Vanals Vanals merged commit ca54877 into main Apr 11, 2022
@Vanals Vanals deleted the chore/PPDSC-2007-re-rolling-release branch April 11, 2022 12:13
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
@Vanals
Chore/ppdsc 2007 rolling back package.json version (#157)
635ce59 
* docs(PPDSC-0000): testing permissions

* docs(PPDSC-0000): removing test changed from readme

* chore(PPDSC-2007): rolling back release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Srinivasan-Ramasamy Srinivasan-Ramasamy Srinivasan-Ramasamy approved these changes

@evgenitsn evgenitsn evgenitsn approved these changes

@jps jps Awaiting requested review from jps

@Xin00163 Xin00163 Awaiting requested review from Xin00163

@pdimova pdimova Awaiting requested review from pdimova

@baburay23 baburay23 Awaiting requested review from baburay23

@mutebg mutebg Awaiting requested review from mutebg

Assignees
No one assigned
Labels
ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vanals @newskit-engineering @evgenitsn @Srinivasan-Ramasamy