Skip to content

Commit

Permalink
feat(PPDSC-2315): use sdk to close doc site batch
Browse files Browse the repository at this point in the history
  • Loading branch information
mstuartf committed Aug 8, 2022
1 parent 4160ba8 commit ac84c30
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
6 changes: 0 additions & 6 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ cypress_defaults: &cypress_defaults
# - batchId: This must be set to the current commit sha for the GitHub integration to work.
# - apiKey: This should be the Team API key (execute only permission).
# - batchName: This can be any value (add as much info as possible to make it easy to find batches).
# - dontCloseBatches: Prevent the SDK from closing the batch after all tests in the suite have run.

# Config specific to each suite is set in the .config.js files.

Expand All @@ -93,7 +92,6 @@ cypress_defaults: &cypress_defaults
applitools_defaults: &applitools_defaults
command: |
echo "export APPLITOOLS_SHOW_LOGS=true" >> $BASH_ENV
echo "export APPLITOOLS_DONT_CLOSE_BATCHES=true" >> $BASH_ENV
echo "export APPLITOOLS_BATCH_ID=${CIRCLE_SHA1}" >> $BASH_ENV
echo "export APPLITOOLS_API_KEY=${APPLITOOLS_API_KEY}" >> $BASH_ENV
echo "export APPLITOOLS_BATCH_NAME=\"${CIRCLE_BRANCH}:${CIRCLE_SHA1:0:7} (${CIRCLE_PULL_REQUEST}, ${CIRCLE_BUILD_URL})\"" >> $BASH_ENV
Expand Down Expand Up @@ -307,10 +305,6 @@ commands:
- run:
name: Run Applitools Docs Site Visual Tests
command: make e2e_visual_test_docs || true
- run:
name: Close the Applitools Batch
command: curl --request DELETE --dump-header - "https://eyesapi.applitools.com/api/sessions/batches/$APPLITOOLS_BATCH_ID/close/bypointerid/?apiKey=$APPLITOOLS_API_KEY"
when: always
- store_artifacts:
path: cypress/screenshots
- store_artifacts:
Expand Down
3 changes: 3 additions & 0 deletions applitools.components.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,7 @@ module.exports = {
concurrency: 20,
viewportSize: {width: 1027, height: 768},
properties: [{name: 'suite', value: 'comps'}],
// Don't close the batch when the suite finishes so that the doc site tests
// that run after will be added to the same batch.
dontCloseBatches: true,
};

0 comments on commit ac84c30

Please sign in to comment.