chore(805): legacy lint fixes

.eslintrc.base.json

@@ -0,0 +1,94 @@
+{
+  "root": true,
+  "ignorePatterns": ["**/*"],
+  "plugins": ["@nrwl/nx"],
+  "settings": {
+    "next": {
+      "rootDir": "site/"
+    }
+  },
+  "env": {
+    "jest": true
+  },
+  "globals": {
+    "page": true,
+    "browser": true,
+    "context": true,
+    "cy": true,
+    "Cypress": true,
+    "window": true
+  },
+  "overrides": [
+    {
+      "files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
+      "rules": {
+        "@nrwl/nx/enforce-module-boundaries": "off",
+        "eslint-comments/no-unused-disable": "off"
+      }
+    },
+    {
+      "files": ["*.tsx"],
+      "extends": ["plugin:@next/next/recommended"],
+      "rules": {
+        "react/prop-types": "off",
+        "react/forbid-prop-types": "error",
+        "react-hooks/exhaustive-deps": "warn",
+        "react/jsx-props-no-spreading": "off",
+        "react/require-default-props": "off",
+
+        "react/jsx-no-useless-fragment": "off",
+        "react-hooks/rules-of-hooks": "warn",
+        "react/display-name": "off",
+        "react/jsx-key": "off"
+      }
+    },
+    {
+      "files": ["*.ts", "*.tsx"],
+      "extends": ["plugin:@nrwl/nx/typescript", "plugin:prettier/recommended", "prettier"],
+      "rules": {
+        "no-undef": "off",
+        "no-var": "off",
+        "no-console": "warn",
+        "func-names": "warn",
+
+        "@typescript-eslint/ban-types": "off",
+        "@typescript-eslint/no-empty-function": "off",
+        "@typescript-eslint/ban-ts-comment": "off",
+        "@typescript-eslint/no-this-alias": "off",
+        "@typescript-eslint/no-non-null-assertion": "off",
+        "@typescript-eslint/no-empty-interface": "off",
+        "@typescript-eslint/no-unused-expressions": "warn",
+        "@typescript-eslint/no-explicit-any": "off",
+        "@typescript-eslint/no-inferrable-types": "off",
+        "@typescript-eslint/no-var-require": "off",
+        "@typescript-eslint/no-var-requires": "off",
+
+        "prettier/prettier": [
+          "error",
+          {
+            "singleQuote": true,
+            "trailingComma": "all",
+            "bracketSpacing": false,
+            "arrowParens": "avoid"
+          }
+        ]
+      }
+    },
+    {
+      "files": ["*.js", "*.jsx"],
+      "extends": ["plugin:@nrwl/nx/javascript"],
+      "rules": {
+        "no-undef": "off"
+      }
+    },
+    {
+      "files": ["*.spec.ts", "*.spec.tsx", "*.test.js", "*.test.jsx"],
+      "env": {
+        "jest": true
+      },
+      "rules": {
+        "no-var": "off"
+      }
+    }
+  ]
+}

.eslintrc.json

@@ -0,0 +1,23 @@
+{
+  "extends": [
+    "plugin:@nrwl/nx/react-typescript",
+    "plugin:@nrwl/nx/react",
+    "plugin:storybook/recommended",
+    "./.eslintrc.base.json"
+  ],
+  "ignorePatterns": ["!**/*"],
+  "overrides": [
+    {
+      "files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
+      "rules": {}
+    },
+    {
+      "files": ["*.ts", "*.tsx"],
+      "rules": {}
+    },
+    {
+      "files": ["*.js", "*.jsx"],
+      "rules": {}
+    }
+  ]
+}

.storybook/addons/tealium/register.js

@@ -65,8 +65,7 @@ const Tool = () => {
   });
 
   return (
-    <>
-      <NewsKitProvider theme={newskitLightTheme}>
+    <NewsKitProvider theme={newskitLightTheme}>
         <ConsentSettingsLink
           privacyManagerId={CONFIG.privacyManagerId}
           gdpr
@@ -87,7 +86,6 @@ const Tool = () => {
           </span>
         </Tooltip>
       </NewsKitProvider>
-    </>
   );
 };
 

.storybook/manager.js

@@ -1,4 +1,3 @@
-import React from "react";
 import {addons} from '@storybook/addons';
 import storybookTheme from './storybook-theme';
 

.storybook/preview.js

@@ -88,6 +88,7 @@ export const parameters = {
   docs: {
     // We create a custom Docs page, using of our components for the header
     page: () => {
+      // eslint-disable-next-line react-hooks/rules-of-hooks
       const docsContext = React.useContext(DocsContext);
       return (
         <ThemeProvider theme={newskitLightTheme}>

docs/scripts.md

@@ -35,7 +35,7 @@ Scripts should be named using the following naming convention:
 
 * `test:unit:comps` -> runs the unit tests on the src folder.
 
-* `test:unit:site` -> runs the unit tests on the site folder.
+* `test:unit:docs` -> runs the unit tests on the site folder.
 
 * `test:visual:comps:ci:percy` -> starts the local storybook and runs the percy storybook tests afterwards.
 

nx.json

@@ -4,16 +4,16 @@
       "runner": "nx/tasks-runners/default",
       "options": {
         "cacheableOperations": [
-          "lint:code:base",
+          "lint:code:comps",
+          "lint:code:docs",
           "lint:code",
           "lint:markdown",
           "lint:next",
           "test:unit:run:local",
           "test:unit:run",
-          "test:unit:dev",
           "test:unit:ci",
           "test:unit:comps",
-          "test:unit:site"
+          "test:unit:docs"
         ]
       }
     }