Nr 341878 use reusable workflow for docker image security checks #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigilioso
reviewed
Dec 11, 2024
Comment on lines
+28
to
+30
| setup_qemu: true | ||
| setup_buildx: true | ||
| setup_go: true |
There was a problem hiding this comment.
nit
I believe these are always needed when building docker images. I'd have put defaults as true to avoid these inputs every time.
There was a problem hiding this comment.
Some don't need buildx and build with a command. Buildx does more than building. Same with others.
There are exceptions so I had to include them.
There was a problem hiding this comment.
Some don't need buildx and build with a command
AFAIK, buildx is needed when we need to build multi-arch images. And we mostly do that. I'm not sure when we wouldn't need it. But not a major thing.
Yeah. All the integrations that release docker images will use it. |
rahulreddy15
deleted the
NR-341878-use-reusable-workflow-for-docker-image-security-checks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successfully tested with the reusable workflow reusable_nightly.yaml.
PR needs to be merged after this newrelic/coreint-automation#97 is merged.