Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database only collection list #28

Merged
merged 6 commits into from
May 23, 2019
Merged

Conversation

camdencheek
Copy link
Contributor

Description of the changes

A highly requested feature is for users to be able to collect everything in a database without the strange nested syntax required before. This allows collection_list to be specified as a JSON array of database names. The integration will auto-discover all the schemas, tables, and indexes in that database and collect metrics for all of them. This may lead to larger collection sizes.

PR Review Checklist

Author

  • add a risk label after carefully considering the "blast radius" of your changes
  • describe the intent of your changes in the description. don't just rewrite your code in prose
  • assign at least one reviewer

Reviewer

  • review code for readability
  • verify that high risk behavior changes are well tested
  • check license for any new external dependency
  • ask questions about anything that isn't clear and obvious
  • approve the PR when you consider it's good to merge

@camdencheek camdencheek merged commit 8dfd576 into master May 23, 2019
@camdencheek camdencheek deleted the database-only-collection-list branch May 23, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant