Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unidici tests #946

Merged
merged 3 commits into from
Oct 11, 2021
Merged

Unidici tests #946

merged 3 commits into from
Oct 11, 2021

Conversation

michaelgoin
Copy link
Member

Proposed Release Notes

Links

Details

  • Removes need for eslint disable in undici versioned tests by adding a general "engines" field to package.json.
  • Adds undici versioned tests for port naming and segment ending on error.

@michaelgoin michaelgoin added the risk: low This change does not impact critical areas of the code and is expected to have minimal risk. label Oct 8, 2021
bizob2828
bizob2828 approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice test additions

@michaelgoin michaelgoin merged commit 7f1d162 into newrelic:main Oct 11, 2021
@michaelgoin michaelgoin deleted the unidici-tests branch October 11, 2021 17:31
@github-actions github-actions bot mentioned this pull request Oct 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bizob2828 bizob2828 bizob2828 approved these changes

Assignees
No one assigned
Labels
risk: low This change does not impact critical areas of the code and is expected to have minimal risk.
Projects
Node.js Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelgoin @bizob2828