Adds fastify v3 middleware mounting and fixes mount location naming #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converts to use wrapMiddlewareMounter and properly set route.
michaelgoin
added
risk: low
michaelgoin
changed the title
bizob2828
approved these changes
Oct 4, 2021
| } | ||
|
|
||
| const args = shim.argsToArray.apply(shim, arguments) | ||
| args[1] = shim.wrapMiddlewareMounter(args[1], mounterSpec) |
There was a problem hiding this comment.
nice work on including route when applicable. TIL. also nice abstraction on code between fastify 2 and 3 instrumentation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Release Notes
Added middleware mounting for fastify v3.
Fixed capturing of mount point for middleware naming.
Links
Details
Note: the inclusion of the hook that fires the middleware 'onRequest' does result in awkward UI formatting with the old UI which does auto formatting.
Without it, you would see something like
Middleware: pathMountedMiddleware /async-return. With it, you see:Middleware: onRequest pathMountedMiddleware//async-return.The newer UI doesn't do any formatting currently so has no impact.