Capistrano - lookup fallback changelog from git #1653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
PR #1498 introduced a regression in the resolution of
changelog
content. Originally, whennewrelic_revision
ornewrelic_changelog
was missing and SCM was in use, revision/changelog was taken from SCM (https://github.com/newrelic/newrelic-ruby-agent/pull/1498/files#diff-8617c3d884fd8d418ce71c6e5c8b3574b405debef725642d04cd1fa2db1d0596L39).However, refactoring kept this logic only for
revision
(https://github.com/newrelic/newrelic-ruby-agent/pull/1498/files#diff-62409e781fcfec20b77d79fd9f324cd395030f9b7ae9fb3a85c4a0e92f7add3dR39), notchangelog
(https://github.com/newrelic/newrelic-ruby-agent/pull/1498/files#diff-62409e781fcfec20b77d79fd9f324cd395030f9b7ae9fb3a85c4a0e92f7add3dR31).This PR adds a fallback to the changelog resolution from GIT.
Reviewer Checklist