Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capistrano - lookup fallback changelog from git #1653

Merged

Conversation

arthurwozniak
Copy link
Contributor

Overview

PR #1498 introduced a regression in the resolution of changelog content. Originally, when newrelic_revision or newrelic_changelog was missing and SCM was in use, revision/changelog was taken from SCM (https://github.com/newrelic/newrelic-ruby-agent/pull/1498/files#diff-8617c3d884fd8d418ce71c6e5c8b3574b405debef725642d04cd1fa2db1d0596L39).

However, refactoring kept this logic only for revision (https://github.com/newrelic/newrelic-ruby-agent/pull/1498/files#diff-62409e781fcfec20b77d79fd9f324cd395030f9b7ae9fb3a85c4a0e92f7add3dR39), not changelog (https://github.com/newrelic/newrelic-ruby-agent/pull/1498/files#diff-62409e781fcfec20b77d79fd9f324cd395030f9b7ae9fb3a85c4a0e92f7add3dR31).

This PR adds a fallback to the changelog resolution from GIT.

Reviewer Checklist

  • Perform code review
  • Add performance label
  • Perform appropriate level of performance testing
  • Confirm all checks passed
  • Add version label prior to acceptance

@CLAassistant
Copy link

CLAassistant commented Nov 29, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the community To tag external issues and PRs submitted by the community label Nov 29, 2022
@fallwith
Copy link
Contributor

Hi @arthurwozniak. Thank you very much for your contribution! Your explanation was helpful and your changes make sense. These changes will be included in the next version of the project gem.

@fallwith fallwith merged commit 34bc8b9 into newrelic:dev Nov 29, 2022
@fallwith
Copy link
Contributor

Hi @arthurwozniak. This change has now gone out with v8.14.0 of the newrelic_rpm gem. Thanks again, and welcome to our CHANGELOG as a recognized contributor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community To tag external issues and PRs submitted by the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants