Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand data returned by entity, make search/fetch consistent #180

Merged
merged 3 commits into from
Mar 11, 2020
Merged

Expand data returned by entity, make search/fetch consistent #180

merged 3 commits into from
Mar 11, 2020

Conversation

jthurman42
Copy link
Contributor

@jthurman42 jthurman42 commented Mar 11, 2020 •
edited
Loading

  • Change the way we generate the GraphQL queries to be composable, and consistent between fetching (GetEntity/GetEntities, and Entity Search)
  • Increase the amount of data Entity returns for ApmApplicationEntity.
  • Add Integration tests for returning additional fields
  • Add Integration tests for base Entity fields
  • Add a few more fields for BrowserApplicationEntity

This does change the type of entities.Entity.Type from string to EntityType which is a breaking change.

@jthurman42 jthurman42 requested a review from ctrombley March 11, 2020 00:43
@jthurman42 jthurman42 marked this pull request as ready for review March 11, 2020 01:00
@jthurman42 jthurman42 self-assigned this Mar 11, 2020
golangcibot
golangcibot reviewed Mar 11, 2020
View reviewed changes
pkg/entities/entity.go Outdated Show resolved Hide resolved
@jthurman42 jthurman42 added breaking-change Breaking Change enhancement New feature or request refactor Code refactoring / cleanup size:M Medium labels Mar 11, 2020
@jthurman42
Copy link
Contributor Author

Need this + release for the CLI

@jthurman42 jthurman42 changed the title Increase entity result Expand data returned by entity, make search/fetch consistent Mar 11, 2020
@jthurman42 jthurman42 requested a review from zlesnr March 11, 2020 03:09
@jthurman42 jthurman42 merged commit 562b0a8 into master Mar 11, 2020
@jthurman42 jthurman42 deleted the jthurman/entities branch March 11, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@ctrombley ctrombley ctrombley approved these changes

@zlesnr zlesnr Awaiting requested review from zlesnr

Assignees

@jthurman42 jthurman42

Labels
breaking-change Breaking Change enhancement New feature or request refactor Code refactoring / cleanup size:M Medium
Projects
None yet
Milestone
Developer Toolkit v1 Readiness
Development

Successfully merging this pull request may close these issues.
3 participants
@jthurman42 @ctrombley @golangcibot