Skip to content

Commit

Permalink
feat(alerts): add GetSyntheticsCondition method (#105)
Browse files Browse the repository at this point in the history
  • Loading branch information
ctrombley authored Jan 22, 2020
1 parent d924846 commit 0906653
Show file tree
Hide file tree
Showing 3 changed files with 40 additions and 2 deletions.
19 changes: 19 additions & 0 deletions pkg/alerts/synthetics_conditions.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ package alerts

import (
"fmt"

"github.com/newrelic/newrelic-client-go/pkg/errors"
)

// ListSyntheticsConditions returns a list of Synthetics alert conditions for a given policy.
Expand Down Expand Up @@ -29,6 +31,23 @@ func (alerts *Alerts) ListSyntheticsConditions(policyID int) ([]*SyntheticsCondi
return conditions, nil
}

// GetSyntheticsCondition retrieves a specific Synthetics alert condition.
func (alerts *Alerts) GetSyntheticsCondition(policyID int, conditionID int) (*SyntheticsCondition, error) {
conditions, err := alerts.ListSyntheticsConditions(policyID)

if err != nil {
return nil, err
}

for _, c := range conditions {
if c.ID == conditionID {
return c, nil
}
}

return nil, errors.NewNotFoundf("no condition found for policy %d and condition ID %d", policyID, conditionID)
}

// CreateSyntheticsCondition creates a new Synthetics alert condition.
func (alerts *Alerts) CreateSyntheticsCondition(policyID int, condition SyntheticsCondition) (*SyntheticsCondition, error) {
resp := syntheticsConditionResponse{}
Expand Down
10 changes: 8 additions & 2 deletions pkg/alerts/synthetics_conditions_integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,15 @@ func TestIntegrationSyntheticsConditions(t *testing.T) {
require.NoError(t, err)
require.NotZero(t, conditions)

// Test: Get
condition, err := alerts.GetSyntheticsCondition(policy.ID, conditions[0].ID)

require.NoError(t, err)
require.NotZero(t, condition)

// Test: Update
created.Name = fmt.Sprintf("test-synthetics-alert-condition-updated-%s", testRandStr)
updated, err := alerts.UpdateSyntheticsCondition(*created)
condition.Name = fmt.Sprintf("test-synthetics-alert-condition-updated-%s", testRandStr)
updated, err := alerts.UpdateSyntheticsCondition(*condition)

require.NoError(t, err)
require.NotZero(t, updated)
Expand Down
13 changes: 13 additions & 0 deletions pkg/alerts/synthetics_conditions_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,19 @@ func TestListSyntheticsConditions(t *testing.T) {
require.Equal(t, expected, actual)
}

func TestGetSyntheticsCondition(t *testing.T) {
t.Parallel()
respJSON := fmt.Sprintf(`{ "synthetics_conditions": [%s] }`, testSyntheticsConditionJson)
alerts := newMockResponse(t, respJSON, http.StatusOK)

expected := &testSyntheticsCondition
actual, err := alerts.GetSyntheticsCondition(testPolicyID, testSyntheticsCondition.ID)

require.NoError(t, err)
require.NotNil(t, actual)
require.Equal(t, expected, actual)
}

func TestCreateSyntheticsCondition(t *testing.T) {
t.Parallel()
respJSON := fmt.Sprintf(`{ "synthetics_condition": %s }`, testSyntheticsConditionJson)
Expand Down

0 comments on commit 0906653

Please sign in to comment.