Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nr 341876 make docker images pre release uniform #103

Merged
merged 12 commits into from
Jan 20, 2025

Conversation

rahulreddy15
Copy link
Contributor

Testing the docker image releases one by one.
Can be merged once thats done.

@rahulreddy15
Copy link
Contributor Author

Tested with all the docker image releases that were automated so far

  • nri-prometheus
  • nri-ecs
  • nri-statsd
  • infrastructure-bundle

Copy link
Member

@paologallinaharbur paologallinaharbur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting on the few changes discussed online

@rahulreddy15 rahulreddy15 force-pushed the NR-341876-Make-docker-images-pre-release-uniform branch from 8cb6733 to 20a57e8 Compare January 20, 2025 07:40
@rahulreddy15
Copy link
Contributor Author

env variables only required by nri-prometheus are set in the nri-prometheus release command.

@rahulreddy15 rahulreddy15 merged commit 45d903c into main Jan 20, 2025
7 checks passed
@rahulreddy15 rahulreddy15 deleted the NR-341876-Make-docker-images-pre-release-uniform branch January 20, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants