Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SR Disabler #2986

Merged
merged 7 commits into from
Feb 26, 2025
Merged

SR Disabler #2986

merged 7 commits into from
Feb 26, 2025

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Feb 26, 2025

About the PR

it self recharges a bit. It's also green.

Give the SR a disabler that fit the SR style.

Why / Balance

Looks good.

How to test

N/A

Media

Simple-Station/Einstein-Engines#1845

Requirements

Breaking changes

N/A

Changelog
🆑 Timfa2112, dvir001

  • add: Added CentCom disabler for the SR.

Copy link
Contributor

github-actions bot commented Feb 26, 2025

RSI Diff Bot; head commit 1df7872 merging into 25302c8
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_EE/Objects/Weapons/Guns/Battery/ccdisabler.rsi

State Old New Status
base Added
equipped-BELT Added
equipped-SUITSTORAGE Added
inhand-left-0 Added
inhand-left-1 Added
inhand-left-2 Added
inhand-left-3 Added
inhand-left-4 Added
inhand-left Added
inhand-right-0 Added
inhand-right-1 Added
inhand-right-2 Added
inhand-right-3 Added
inhand-right-4 Added
inhand-right Added
mag-unshaded-0 Added
mag-unshaded-1 Added
mag-unshaded-2 Added
mag-unshaded-3 Added
mag-unshaded-4 Added

Edit: diff updated after 1df7872

@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Feb 26, 2025
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only real question I have here is about the issuance of centcomm stuff to the SR - I get that the colour schemes are derivative but between this and the pen, that's about it.

Works as expected and not overly busted given the disabler SMG is a thing. Seems like a easonable addition.

@dvir001 dvir001 merged commit eb67f32 into new-frontiers-14:master Feb 26, 2025
14 checks passed
FrontierATC added a commit that referenced this pull request Feb 26, 2025
@arimah
Copy link
Contributor

arimah commented Feb 26, 2025

This PR should never have been merged with a reason like "Looks good". What the fuck?

Why does the SR need their own magically recharging stun meta? They mostly hang out on FO, where fighting is a rule break and hostile mobs are outright ashed.
If the SR is pirated outside the safe zone, why should they have a random stun advantage? They're a pencil pusher!

@arimah
Copy link
Contributor

arimah commented Feb 26, 2025

Addendum:

  • The SR already has a pair of magical self-recharging disabler turrets that deal with by far the most common safezone violation people engage in
  • "CentComm" means admin. The SR is not an admin. Even if they're being played by one. Their CC pen is problematic enough, let alone a weapon. :|

@whatston3
Copy link
Contributor

Why does the SR need their own magically recharging stun meta? They mostly hang out on FO, where fighting is a rule break and hostile mobs are outright ashed.

If it's that much of a concern, this can be reverted. If you're going down this line of reasoning, then why have one at all?

"CentComm" means admin.

Only real question I have here is about the issuance of centcomm stuff to the SR

Yes. As an in-game representative of NT's central command, it's not outrageous to have the occasional mug or bit of CC tat. To be fair, the fact that the station rep uses a deep green is also a confounding factor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants