Hotfix explosive bolt being craftable via anything with Comp Explosive

[nathan736]

this included RTGS & Air tanks for some reason, moved the targeting requirement to a Firebomb tag. which might not be optimal but works.

About the PR

Why / Balance

Fixes a glaring issue reported in Bug reports
https://discord.com/channels/1123826877245694004/1343433692139225139/1343433692139225139

How to test

Attempt to create a explosive bolt with an RTG instead of the firebomb (reported to be able to be done with any explosive comp including airtanks)

Media

no longer able to be crafted with an RTG

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

• fix: Explosive bolts can now only be crafted with firebombs.

[nathan736]

This is my First attempt of this kind so this Might be a very poor method to fix this
I am not Attatched to the tags name at all and there's likely a better name for it

[dvir001]

Convert to empty component, no new tag please.

[whatston3]

This is my First attempt of this kind so this Might be a very poor method to fix this I am not Attatched to the tags name at all and there's likely a better name for it

Thanks for the contribution. It's reasonable, but I think dvir's right on this one.

The reason we don't like tags is that they always push complete inheritance - if you create a new tag and tag an item with only that (as you did here), you remove all previous tags (unsure if it's an issue in this particular case). If you look at Content.Server/_NF/Whitelist/Components, you'll see a bunch of empty [components] used for tagging items to avoid this issue.

A better longer-term solution would be to build support for an NFTag that can add and remove tags from a particular entity, rather than specifying a complete set, but that's a bit more involved.

[dvir001]

Looking good.

[dvir001]

Should we not put the comp in shared? @whatston3

[whatston3]

We could move all of the whitelist components into shared, and it's probably a good idea. At the moment, the only time this would get used is in a construction graph with a ghost, which we do not have.

Works as-is, but might break if construction graphs are moved to be more predicted.

[whatston3]

Swapped the component name over from NFExplosivecrafting (vague, not camel case) to NFFireBomb. Works fine.