Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDA bounty contracts rework #2967

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

Cheackraze
Copy link
Member

@Cheackraze Cheackraze commented Feb 22, 2025

About the PR

Splits the PDA bounty contracts system into two, creating a board that is accessible to civilians as well as official station staff.

TODO:
[x] Change Notifications from PDAs to match the news article alert format for consistency
[ ] Allow civilian level access players to remove their own bounty entries

Why / Balance

Allow for better communication between players looking for better intercrew cooperation.

How to test

Load in as a contractor or other civilian role, create edit and delete your own bounties for job postings, shop advertisements, work orders and more.

Media

Requirements

Breaking changes

Changelog

🆑 whatston3

  • tweak: Changed the bounty board system to allow civilian use.

@Cheackraze Cheackraze added Enhancement New feature or request S: Awaiting Changes This PR has changes that need to be made before merging S: DO NOT MERGE and removed Enhancement New feature or request labels Feb 22, 2025
@Clay500z
Copy link

Finally, job postings in the newspaper. Frontier may yet recover from it's unemployment crisis

@whatston3
Copy link
Contributor

Should largely be fine, but a timeout between bounties would be good.

Fixed an issue with the write access check, privileges work as expected.

Touched up the UI, entries should be smaller - went ahead with the button grid thing, it seems to look alright to my eye. Description is omitted entirely if empty, and names, vessels, and descriptions are given maximum lengths. I assume enough characters for a tweet is fine for a description.

@github-actions github-actions bot added size/L and removed size/M labels Feb 24, 2025
@whatston3
Copy link
Contributor

whatston3 commented Feb 24, 2025

Alrighty.

Took forever, but I think it's in a good enough place.

Lists are now in reverse chronological order - newer posts show up at the top.
Added a 20 second cooldown (comparable to news stories, but everybody has a PDA vs. a mass media console, might need a bump)
Added a notification toggle for public posts (currently only shows on the list screen, not when creating a post - state needs some rework if you want it on the create screen)
Restored the beige announcement text for Command posts (swapped the bold text and the regular text) - configurable by the collection.
Messages have custom announcement types per category ("New job vacancy posted for [NAME]. Reward: $5,000.")
Vessel fields and job titles are generally omitted if left unknown - job titles were commented out, ID cards don't seem to have JobTitle populated at present.

Issues:

  • When a new bounty is placed, your state currently clears if you're writing your own. I believe this was a pre-existing issue.
  • Cooldown is not actually displayed anywhere.
  • When opening the create screen, the name shows a dropdown vs. custom name entry regardless of what category is shown (depends on the collection).

@whatston3 whatston3 added S: Needs Review This PR is awaiting reviews and removed S: Awaiting Changes This PR has changes that need to be made before merging S: DO NOT MERGE labels Feb 24, 2025
@dvir001 dvir001 changed the title Big Bounty Riches PDA bounty contracts rework Feb 24, 2025
@Cheackraze
Copy link
Member Author

The actual solution to notifications is to move that control out of both the bounty system and news reader system and put it into the "OS" of the PDA screen itself, especially since both systems are now utilizing the in-built cartridge reader's functionality for the alerts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants