Black market access configurator for pirates

[Houtblokje]

About the PR

This PR adds a black market access configurator, so pirates can lock newly built doors and crates behind pirate access that was added in #2893.
It also has syndicate access, mainly for flavour and so admins can use it in events. This shouldn't affect pirates, since you cannot use what is not on your ID.
It is available for 3 dubloons in the pirate uplink.

The sprite is recolored from the regular access configurator. I am not fully sure if the meta.json information has been filled out correctly.

Why / Balance

More stuff for pirates to buy, plus I think it would make modifying pirates ships easier for them.

How to test

Use golobby to go to the lobby screen and spawn as a pirate captain.
Use your uplink to buy the access configurator from the utilities tab.
Put your id card in it and start modifying.

Media

Recolored sprite, with red colors to symbolize the evil.

Configurator has all the basic access contractors can have + Pirates and syndie. Pirates can only use the access they actually have.

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

• add: Pirate captains can now buy a black market access configurator.

[github-actions]

RSI Diff Bot; head commit 08b3382 merging into a1b2010
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Tools/antag_access_configurator.rsi

State	Old	New	Status
equipped-BELT			Added
icon			Added
inhand-left			Added
inhand-right			Added

Edit: diff updated after 08b3382

[whatston3]

A few thoughts.

1. Pirates shouldn't be able to lock down POIs or other people's ships - frankly, nor should the NFSD. If you need to enforce a quarantine, do it with the presence of people. The NFSD access configurator was a mistake, and the Pirate access and this are the fallout of it. I think the solution might be grid-based configuration - NFSD ships being configurable, great, pirate ships being configurable, great, everything else, probably not.
2. Pirates shouldn't really have the ability to adjust accesses beyond Pirate - other antag factions should have their own accesses, the Pirates are distinct from the Syndicate. Even with pirate access, it should only be on Pirate shuttles and stations. Captain here doesn't make a ton of sense, I understand why the door on the (Falcon?) is there - if we need pirate captain access to be a thing (and it's for one current mapped door), we should make it its own thing, but I don't think it's relevant, and the command door should just be pirate-accessible. The pirate console itself likely shouldn't even give the Captain access, or rename the player's role.

[Houtblokje]

A few thoughts.

1. Pirates shouldn't be able to lock down POIs or other people's ships - frankly, nor should the NFSD. If you need to enforce a quarantine, do it with the presence of people. The NFSD access configurator was a mistake, and the Pirate access and this are the fallout of it. I think the solution might be grid-based configuration - NFSD ships being configurable, great, pirate ships being configurable, great, everything else, probably not.

I did lock it to pirate captains uplink only, partially for this reason, since I assume they would handle it a little bit more responsably.
I think this is the main issue that needs some discussion, since issue 2 consists things that can easily be resolved, but if there is a fundamental flaw in the nature of this PR, then that is a much bigger issue.

2. Pirates shouldn't really have the ability to adjust accesses beyond Pirate - other antag factions should have their own accesses, the Pirates are distinct from the Syndicate. Even with pirate access, it should only be on Pirate shuttles and stations. Captain here doesn't make a ton of sense, I understand why the door on the (Falcon?) is there - if we need pirate captain access to be a thing (and it's for one current mapped door), we should make it its own thing, but I don't think it's relevant, and the command door should just be pirate-accessible. The pirate console itself likely shouldn't even give the Captain access, or rename the player's role.

Two things here, so I will respond to both of them. I think the captain's access could be removed if you feel like it doesn't make sense. Arguably, so could the mercenary access.
I do think pirate captain and maybe even first mate access levels should be added, but that is probably not something that should be in this PR.

As for the "Pirates should not be able to edit other accesses", the idea here was that this was a general tool sold on the black market. Practically, the pirates cannot use it for anything other than their own access, because they simply lack the necessary access permissions on their ID cards. I just added the syndicate access because 1. The pirates might have bought this from a syndicate source, or from some other shady figure that also sells it to the syndicate and 2. Having it be one item would allow admins to give it to "syndicates" whenever they feel like it is necessary, without having to give away an admin one.
It would also allow possible future syndicate antags to use this right from the start without having to define a seperate one.

That was my reasoning for the syndicate access on it.

[Houtblokje]

I have removed all the access levels that do not make sense, as requested.
As for the first point, with restrictions on POI's possibly being needed, that would probably require code and that is beyond my abilities. I personally think that pirate captains should be able to be trusted with an access configurator, just like the sheriff and the SR are, but I leave this to your judgement.

[Cheackraze]

ideally, access could be made more generic and dynamic like whatstone said and allow per-ship granular access. This would affect civillian captains as well letting them control access on their own ships as well. Similar ideas around radio comms we have had in the past.

I do think that this is an acceptable middle ground, and since we only allow more trusted players access to these tools, I think its ok to accept for now with the knowledge that we may remove or alter this if we see it being abused.