Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a civilian grade bananium generator for heavy shuttles and stations. #2882

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

dustylens
Copy link
Contributor

@dustylens dustylens commented Feb 8, 2025

About the PR

  • Adds the ProfPacman generator. A c1 generator that mirrors the HyperPacman (at present) for the purposes of providing an AME alternative for heavy shuttles and stations.
  • Tier 3 research option for the same.
  • Blueprints and crafting recipes.
  • Returns bananium to the fuel vend.

Why / Balance

It's time.

Long since past time really.

This is an excellent generator for Frontier. It would be excellent to map on a number of shuttles and facilities. Its current place as 80% meme and 20% rare but illegal loot feels like something that has moved past its time.

I believe that this generator could fill a niche that is otherwise occupied by the AME far more cleanly on a number of designs. Furthermore I do not believe that a suitably mapped shuttle would lack for the safety equipment required to facilitate its use without making it a death sentence.

It has existed in Frontier for some time without incident. I believe it's time.

How to test

Check fuel vend.
Check contraband description.
Ensure that the lathe/research recipes aren't scuffed. That one is always complicated and weird.

Media

ss+(2025-02-08+at+02 14 56)

Requirements

Breaking changes

Changelog

🆑

  • tweak: HYPERPACMAN renamed to D-K generator, lowered to class 2 contraband.
  • add: Add a class 1, civilian-grade bananium generator, researchable through science and printable through blueprints.

@Houtblokje
Copy link
Contributor

Actually not a bad idea. Use it to poison everyone, and its a felony. But use it properly and you are fine.

@github-actions github-actions bot added size/M and removed size/XS labels Feb 8, 2025
@dustylens dustylens changed the title Hyperpacman reclassified as C1 New Prof Pacman generator. Civilian rated Hyper Pacman alternative for heavy shuttles and stations. Feb 8, 2025
@dustylens
Copy link
Contributor Author

PR updated and etc.

@dvir001
Copy link
Contributor

dvir001 commented Feb 12, 2025

I'll probably down this to 40k normal, 80k max so the contra one still valid, and lower the rads to half.

No changes needed for hyper.

@dustylens
Copy link
Contributor Author

Disagree. With a tier 3 research requirement, mapping needs, death potential and the additional cost? I'd keep this generator as is and really lean into the hyper as a "ooooh" find. Let the hyper crank up to 80/120 and knock you right on you rear.

…both. Dvir is happy and the mchobo is lethal.
@dustylens
Copy link
Contributor Author

Updated the Hyper Pacman to 120/80 to align with the request for differentiation.

@Houtblokje
Copy link
Contributor

Houtblokje commented Feb 15, 2025

Updated the Hyper Pacman to 120/80 to align with the request for differentiation.

Isn't that roughly what an AME produces? Is that something that is fine or will the AME also be upped in power output (in which case we might have some kind of power creep?)

@dustylens
Copy link
Contributor Author

At the present the only plans that I am aware of is that the hyperpacman will remain a rare to extremely rare contraband find and there are no current plans for the AME.

@Tych0theSynth
Copy link
Contributor

Tych0theSynth commented Feb 15, 2025

I'll probably down this to 40k normal, 80k max so the contra one still valid, and lower the rads to half.

No changes needed for hyper.

No thanks. Let this be a viable alternative to smaller ships that would otherwise need an AME which is completely overkill.
Please don't bust this thing down and make life harder for mappers for the sake of a meme item. Let us have this bit of QOL that saves us nine tiles of space on ships which clearly don't need an AME.

@dvir001
Copy link
Contributor

dvir001 commented Feb 15, 2025

This PR is good as it is, going to merg it soon unless someone has feedback to add.

@dvir001 dvir001 self-requested a review February 15, 2025 21:28
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Feb 15, 2025
@whatston3 whatston3 self-assigned this Feb 17, 2025
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, but I do have a few suggestions.

  1. The PROFPACMAN should probably be less radioactive overall.
  2. The HYPERPACMAN should probably consume more fuel than it does (it's currently incredibly strong) but serve more of a purpose in radiation collection.
  3. We could reduce the HYPERPACMAN to class 2 contraband so it'd be runnable with permission (why not - it's dangerous but serves a mechanical purpose, should let people play with the toys)

dustylens and others added 4 commits February 17, 2025 22:33
@whatston3
Copy link
Contributor

whatston3 commented Feb 18, 2025

Got a set of suggestions up here: https://github.com/dustylens/frontier-station-14/compare/hyperpacman-rationalization-pass...whatston3:frontier-station-14:2025-02-18-dankey-kang?expand=1

  1. Reduces the overall fuel efficiency of bananium reactors (360 kJ per 30 units of nanners to 240 at optimal settings [60 kW]) - this is still quite strong and only stronger with the possibility of radiation collection (rework soon™)
  2. Reduces radiation intensity of the civilian version, 4 rad/s max at max settings - you can still stack these to get better results, but the full one is more desirable for radiation generation.
  3. Renames the HYPERPACMAN (long name, bad) to the D-K (cheesy reference, banana, good), and the PROFPACMAN to the D-K Jr.
  4. Renames both prototypes and all mapped instances of these, adds a migration for downstream buddies.
  5. Reduces fuel curve coefficient of the D-K to 0.5 (Jr. still at 0.75) - compromise with super high radiation source: the thing eats fuel.
  6. Reduces the D-K reactor to class 2 contraband, removes all FUC value - incentivize people actually running the thing vs. pawning it for gamer loot.

@dustylens
Copy link
Contributor Author

Discussed Whatstone's suggestions with them and they generally strike me as a positive and interesting direction to take things. Pending maintainer blessing on moving things in this direction consider my position a thumbs up and feel free to merge them in.

@dustylens
Copy link
Contributor Author

Just checking in. Is this PR good to go as is? Or is it pending a rebuild of some type?

@whatston3
Copy link
Contributor

Just checking in. Is this PR good to go as is? Or is it pending a rebuild of some type?

If it's alright by you, merge in that D-K branch, then this seems fine to me. Others might disagree, but I'd approve it.

@github-actions github-actions bot added Map-POI Map - POI Map-Dungeon Map - Dungeon C# labels Feb 25, 2025
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nanner strats.

@whatston3 whatston3 changed the title New Prof Pacman generator. Civilian rated Hyper Pacman alternative for heavy shuttles and stations. Add a civilian grade bananium generator for heavy shuttles and stations. Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Map-Dungeon Map - Dungeon Map-POI Map - POI No C# S: Needs Review This PR is awaiting reviews size/M YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants