Add grpc option IncludePoolData to QueryUserDeposits
#390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr0n00gler
previously approved these changes
Jan 24, 2024
swelf19
reviewed
Jan 30, 2024
There was a problem hiding this comment.
- pls regenerate openapi
- neutron-sdk's proto files has to be regenerated https://github.com/neutron-org/neutron-sdk/tree/main/packages/neutron-sdk/src/proto_types
| @@ -18,4 +19,11 @@ message DepositRecord { | |||
| int64 lower_tick_index = 4; | |||
| int64 upper_tick_index = 5; | |||
| uint64 fee = 6; | |||
| string total_shares = 7 [ | |||
| (gogoproto.moretags) = "yaml:\"total_shares\"", | |||
| (gogoproto.customtype) = "github.com/cosmos/cosmos-sdk/types.Int", | |||
There was a problem hiding this comment.
github.com/cosmos/cosmos-sdk/types.Int is deprecated and it is an alias to cosmossdk.io/math.Int. But it's not necessary to fix it right now. We want to move sometime, but in standalone task
|
manually regenerated proto for neutron-sdk here: neutron-org/neutron-sdk#127 |
pr0n00gler
previously approved these changes
Feb 8, 2024
NeverHappened
previously approved these changes
Feb 12, 2024
swelf19
previously approved these changes
Feb 12, 2024
jcompagni10
dismissed stale reviews from swelf19, NeverHappened, and pr0n00gler
via
2791e5d
|
NOTE: openapi.yml has been generated with ignite v28.2.0 |
NeverHappened
approved these changes
Feb 15, 2024
swelf19
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to facilitate easier state computation for the duality frontend additional pool data needs to be included in the UserDepositsQuery. See duality-labs/duality-web-app#493 for more details