Include OS version in github action cache for cppcheck #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nexarian
approved these changes
Mar 4, 2021
abitmore
added a commit
to bitshares/bitshares-core
that referenced
this pull request
Jul 5, 2021
This fixes an issue when Github changes `ubuntu-latest` environment from `18.04` to `20.04`, and avoids similar issues in the future. The fix is inspired by neutrinolabs/xrdp#1821 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes the OS version in the cppcheck cache name for the cppcheck github action.
This ensures that when
ubuntu-latestis updated, we do not use the old cache - moving from 18.04 to 20.04 broke cppcheck as the symbolZ3_get_error_msgwas removed from the Z3 library - see Z3Prover/z3#660