Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: reduce size of wheels (hide unused but previously public API) #202

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

neutrinoceros
Copy link
Owner

These changes lead to a significant reduction in wheel size (at least on Mac arm64), but removing the Python impl of core algorithms is technically a breaking change so the next version would be 2.0.0

@neutrinoceros neutrinoceros force-pushed the bld/smaller_wheels branch 2 times, most recently from 37c1af7 to 65dd899 Compare June 28, 2024 19:22
@neutrinoceros neutrinoceros changed the title API: reduce size of wheels: - merge cython source files (reduce disk overhead from generated boilerplate code) - exclude unused Python implementation of core algorithm from distributions API: reduce size of wheels (drop unused but previously public API) Jun 28, 2024
@neutrinoceros neutrinoceros changed the title API: reduce size of wheels (drop unused but previously public API) API: reduce size of wheels (hide unused but previously public API) Jun 28, 2024
@neutrinoceros
Copy link
Owner Author

I don't know what's up with CI not starting right now but I'll try again later.

@neutrinoceros neutrinoceros reopened this Jun 29, 2024
@neutrinoceros neutrinoceros force-pushed the bld/smaller_wheels branch 4 times, most recently from 21adba0 to 6df60a0 Compare June 29, 2024 08:36
- merge cython source files (reduce disk overhead from generated boilerplate code)
- exclude unused Python implementation of core algorithm from distributions
@neutrinoceros neutrinoceros marked this pull request as ready for review June 29, 2024 09:34
@neutrinoceros neutrinoceros merged commit 7bc8567 into main Jun 29, 2024
14 checks passed
@neutrinoceros neutrinoceros deleted the bld/smaller_wheels branch June 29, 2024 09:34
@neutrinoceros neutrinoceros added this to the v2.0.0 milestone Jun 30, 2024
@neutrinoceros neutrinoceros added the API breaking change label Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant