Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Python 3.8, add tests #8

Merged
merged 13 commits into from
Sep 1, 2020
Merged

Move to Python 3.8, add tests #8

merged 13 commits into from
Sep 1, 2020

Conversation

adelavega
Copy link
Member

@adelavega adelavega commented Sep 1, 2020

WIP. Adding a set of comprehensive tests in Python 3.8.

Closes #6
Closes #7

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@8996e89). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #8   +/-   ##
=========================================
  Coverage          ?   62.77%           
=========================================
  Files             ?       22           
  Lines             ?      693           
  Branches          ?        0           
=========================================
  Hits              ?      435           
  Misses            ?      258           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8996e89...cc496aa. Read the comment docs.

@adelavega adelavega requested a review from tyarkoni September 1, 2020 21:48
@adelavega
Copy link
Member Author

@tyarkoni I added some basic tests for all the API routes. Looks like some routes (e.g. images datasets) aren't populated by ingest_neurosynth so can add tests for those later by creating fixtures, but I need to familiarize myself more with those models.

@tyarkoni
Copy link
Contributor

tyarkoni commented Sep 1, 2020

@adelavega great, thanks! ingest_neurosynth shouldn't populate either of those models, so that's fine—images is for image-based data (Neurosynth is only coordinates), and datasets is a NIMADS constructions (it's basically a container for a set of annotated studies).

@adelavega
Copy link
Member Author

Okay yep that's what I thought!

@adelavega adelavega merged commit 9b828d5 into master Sep 1, 2020
@adelavega adelavega mentioned this pull request Sep 1, 2020
@jdkent jdkent deleted the enh/test branch February 27, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to Python 3.8 Add tests
3 participants