Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] add frontend config #249

Merged
merged 37 commits into from
May 10, 2022
Merged

[ENH] add frontend config #249

merged 37 commits into from
May 10, 2022

Conversation

jdkent
Copy link
Member

@jdkent jdkent commented Mar 28, 2022

add configuration for frontend to create options for specifying meta-analyses.

each parameter now has: "type", "description", and "default", so you can prefill certain options with the default value. In addition, each Estimator/class has a "Summary" so you can give a hoverable/inline description of the choices the user has when selecting. Finally, I added CORRECTOR and populated IBMA with algorithms, so that Algorithm and Corrector selection can be completed.

  • current drawbacks:

    • does not include optional arguments of base classes (e.g., masker, resample_kwargs)
    • some string arguments are actuallly references to files (need file upload feature?)
  • replace single quotes with double quotes in the config (invalid json) @jdkent

Copy link
Member

@adelavega adelavega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One minor comment

synth/neurosynth-frontend/scripts/parse_nimare_docs.py Outdated Show resolved Hide resolved
},
"xyz": {
"description": "Tab-delimited file of coordinates from database or numpy array with XYZ coordinates. Voxels are rows and x, y, z (meaning coordinates) values are the three columnns.",
"type": "str",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will likely need to be a file upload (not just a string).

@nicoalee nicoalee linked an issue Apr 7, 2022 that may be closed by this pull request
@jdkent jdkent mentioned this pull request Apr 28, 2022
@nicoalee nicoalee merged commit e2dcec0 into master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build meta analysis creation page
3 participants