Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper bound for matplotlib version #751

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Conversation

ghisvail
Copy link
Contributor

@ghisvail ghisvail commented Nov 7, 2022

Since version 0.9.1, nilearn declares extra dependencies for its plotting capabilities.

This PR drops the explicit dependency on a bounded version of matplotlib and let it be installed transitively through nilearn. Another benefit is to allow projects depending on NiMARE explicitly or transitively to install more recent versions of matplotlib which provides wheels for Python 3.10+.

This PR drops the upper bound of the matplotlib requirement to allow install of more recent versions which provides wheels for Python 3.10+.

@welcome
Copy link

welcome bot commented Nov 7, 2022

Thanks for opening this pull request! We have detected this is the first time you have contributed to NiMARE. Please check out our contributing guidelines.
We invite you to list yourself as a NiMARE contributor, so if your name is not already mentioned, please modify the .zenodo.json file with your data right above Angie's entry. Example:

{
  "name": "Contributor, New",
  "affiliation": "Department of Psychology, Some University",
  "orcid": "<your id>"
},
{
  "name": "Laird, Angela R.",
  "affiliation": "Florida International University",
  "orcid": "0000-0003-3379-8744"
},

Of course, if you want to opt out this time there is no problem at all with adding your name later. You will be always welcome to add it in the future whenever you feel it should be listed.

@ghisvail
Copy link
Contributor Author

ghisvail commented Nov 7, 2022

Successfully installed NiMARE-0.0.12+19.gf523475.dirty certifi-2022.9.24 charset-normalizer-2.1.1 cognitiveatlas-0.1.9 contourpy-1.0.6 cycler-0.11.0 fonttools-4.38.0 future-0.18.2 idna-3.4 joblib-1.2.0 kiwisolver-1.4.4 llvmlite-0.39.1 lxml-4.9.1 matplotlib-3.6.2 nibabel-4.0.2 nilearn-0.9.2 numba-0.56.4 packaging-21.3 pandas-1.5.1 patsy-0.5.3 pymare-0.0.4rc2 python-dateutil-2.8.2 requests-2.28.1 scikit-learn-1.1.3 scipy-1.9.3 sparse-0.13.0 statsmodels-0.13.5

@ghisvail
Copy link
Contributor Author

ghisvail commented Nov 8, 2022

I forgot to update the minimum group of dependencies accordingly. This is done now.

@jdkent
Copy link
Member

jdkent commented Nov 8, 2022

thanks for this contribution @ghisvail! looks like the max matplotlib version is 3.3.4 when using python 3.6:

https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.4.0.html#increase-to-minimum-supported-versions-of-python-and-dependencies

@ghisvail
Copy link
Contributor Author

looks like the max matplotlib version is 3.3.4 when using python 3.6

Thanks for confirming. I have updated it.

@ghisvail ghisvail changed the title Drop explicit dependency on matplotlib Remove upper bound for matplotlib version Nov 13, 2022
@ghisvail
Copy link
Contributor Author

Went for a different strategy because the initial proposal does not work for the minimum requirements set for Python 3.6.

@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Base: 88.05% // Head: 88.05% // No change to project coverage 👍

Coverage data is based on head (33801ed) compared to base (87f4559).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #751   +/-   ##
=======================================
  Coverage   88.05%   88.05%           
=======================================
  Files          35       35           
  Lines        3886     3886           
=======================================
  Hits         3422     3422           
  Misses        464      464           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jdkent jdkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@tsalo
Copy link
Member

tsalo commented Nov 17, 2022

Thanks @ghisvail. Also thanks to @jdkent for reviewing. I'll merge it now.

@tsalo tsalo merged commit abb8feb into neurostuff:main Nov 17, 2022
@tsalo tsalo added the maintenance Issues/PRs related to maintenance/infrastructure. label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues/PRs related to maintenance/infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants