-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove upper bound for matplotlib version #751
Conversation
Thanks for opening this pull request! We have detected this is the first time you have contributed to NiMARE. Please check out our contributing guidelines.
Of course, if you want to opt out this time there is no problem at all with adding your name later. You will be always welcome to add it in the future whenever you feel it should be listed. |
Successfully installed NiMARE-0.0.12+19.gf523475.dirty certifi-2022.9.24 charset-normalizer-2.1.1 cognitiveatlas-0.1.9 contourpy-1.0.6 cycler-0.11.0 fonttools-4.38.0 future-0.18.2 idna-3.4 joblib-1.2.0 kiwisolver-1.4.4 llvmlite-0.39.1 lxml-4.9.1 matplotlib-3.6.2 nibabel-4.0.2 nilearn-0.9.2 numba-0.56.4 packaging-21.3 pandas-1.5.1 patsy-0.5.3 pymare-0.0.4rc2 python-dateutil-2.8.2 requests-2.28.1 scikit-learn-1.1.3 scipy-1.9.3 sparse-0.13.0 statsmodels-0.13.5 |
I forgot to update the minimum group of dependencies accordingly. This is done now. |
thanks for this contribution @ghisvail! looks like the max matplotlib version is 3.3.4 when using python 3.6: |
Thanks for confirming. I have updated it. |
Went for a different strategy because the initial proposal does not work for the minimum requirements set for Python 3.6. |
Codecov ReportBase: 88.05% // Head: 88.05% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
=======================================
Coverage 88.05% 88.05%
=======================================
Files 35 35
Lines 3886 3886
=======================================
Hits 3422 3422
Misses 464 464 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution!
Since version 0.9.1,
nilearn
declares extra dependencies for its plotting capabilities.This PR drops the explicit dependency on a bounded version ofmatplotlib
and let it be installed transitively throughnilearn
. Another benefit is to allow projects depending onNiMARE
explicitly or transitively to install more recent versions of matplotlib which provides wheels for Python 3.10+.This PR drops the upper bound of the matplotlib requirement to allow install of more recent versions which provides wheels for Python 3.10+.