Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vfwe_only in CBMAEstimator even when null_method isn't montecarlo #678

Merged
merged 4 commits into from
Apr 29, 2022

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Apr 28, 2022

Closes #385. Most of this code is excised from #659.

Changes proposed in this pull request:

  • Allow vfwe_only, even when null_method == 'approximate'. This should run more quickly than the cluster-level approach.

@tsalo tsalo added enhancement New feature or request cbma Issues/PRs pertaining to coordinate-based meta-analysis correct Issues related to the correct module labels Apr 28, 2022
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #678 (848564d) into main (6cd751e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #678   +/-   ##
=======================================
  Coverage   85.28%   85.29%           
=======================================
  Files          40       40           
  Lines        4513     4516    +3     
=======================================
+ Hits         3849     3852    +3     
  Misses        664      664           
Impacted Files Coverage Δ
nimare/meta/cbma/base.py 96.56% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cd751e...848564d. Read the comment docs.

@tsalo tsalo merged commit b818512 into neurostuff:main Apr 29, 2022
@tsalo tsalo deleted the vfwe-only branch April 29, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cbma Issues/PRs pertaining to coordinate-based meta-analysis correct Issues related to the correct module enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement pure voxel-level Monte Carlo FWE correction for CBMA Estimators
1 participant