-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manual changelog to documentation #635
Conversation
Codecov Report
@@ Coverage Diff @@
## main #635 +/- ##
==========================================
- Coverage 85.32% 85.28% -0.04%
==========================================
Files 41 41
Lines 4503 4507 +4
==========================================
+ Hits 3842 3844 +2
- Misses 661 663 +2
Continue to review full report at Codecov.
|
@JulioAPeraza I'm only now realizing that using MarkDown for the changelog really limits it. The main thing I'd like to have is admonitions for version-specific warnings (e.g., don't use |
I think the Github Action I am using only export to |
Okay, thanks for the clarification. I can just use bolded text or something. It's probably not worth it to try to convert the Markdown to RST if it's not just a simple setting.
The fix is documented in the ALESubtraction docstring, I believe.
Yes, we will generally only know about version-specific problems after the releases have been made, so we will add those notes manually. EDIT: The good news is that it looks like the RST admonitions render properly in the Sphinx-built docs, so it's not a big deal. The only place where the admonitions won't render is looking directly at the Markdown file. |
@JulioAPeraza Can you take a look at the proposed changelog format and see how it will compare to the automatic one you added? |
I was looking at other projects that use this action and the only difference will be in the date of the release. They use |
I'm glad the date is in there at least. I'll change the format for the manually-created ones to match the new format. |
CHANGELOG.md
Outdated
* Replace multiprocessing with joblib for parallelization and change n_cores default to 1 by @tsalo in https://github.com/neurostuff/NiMARE/pull/597 | ||
* Incorporate joblib into ALESubtraction and fix SCALE docstring by @tsalo in https://github.com/neurostuff/NiMARE/pull/641 | ||
### 🎉 Exciting New Features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these headings include blank lines before and after?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied them from the release notes, so I think the problem is in the template.
However, I think the rendered changelog looks okay, so I don't know if it's an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the issue in the previous docs build. I only see the first heading ### 🛠Breaking Changes
, the other ones (### 🎉 Exciting New Features
, ### 🐛 Bug Fixes
, and ### Other Changes
) are mixed in the text.
If that is the case, it may be an issue for the automatic changelog, since it will copy the body of the release notes as it is (without blank lines between ###
headings).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhh... nice catch. I completely missed that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how to fix this though... the template doesn't seem to let us control spacing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully the auto-generated version will look okay. I'll merge this once CI passes and then I'll make a release (0.0.12rc4 😬).
Closes #603. This isn't an automated solution, but it does give me the control I need to add things like warnings to old versions.
Changes proposed in this pull request:
docs/changelog.rst
.docs/index.rst
.