Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error and diff handling #84

Merged
merged 13 commits into from
Jun 3, 2023
Merged

Improve error and diff handling #84

merged 13 commits into from
Jun 3, 2023

Conversation

olupton
Copy link
Collaborator

@olupton olupton commented May 31, 2023 •
edited
Loading

  • Previously error code 1 was counted as success.
  • When gout diffs were large, making the HTML report could be very slow. Add a timeout.
  • Start to address more issues in new and existing models.

olupton
olupton commented Jun 2, 2023
View reviewed changes
@olupton olupton marked this pull request as ready for review June 2, 2023 13:07
@olupton olupton requested a review from alexsavulescu June 2, 2023 13:07
@olupton olupton merged commit 7b95867 into master Jun 3, 2023
@olupton olupton deleted the olupton/fixups branch June 3, 2023 07:00
@olupton olupton mentioned this pull request Jun 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsavulescu alexsavulescu alexsavulescu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olupton @alexsavulescu