-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix installation link and add quick install #185
Conversation
It was returning 404
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 11 11
Lines 638 638
=======================================
Hits 636 636
Misses 2 2 ☔ View full report in Codecov by Sentry. |
Questions/suggestions:
|
There's already link checking right via sphinx? |
yeah, but I think atm it doesn't include the repo's README. Is that right @niksirbi? |
Oh yeah, sorry. That is correct (I think). |
I think the two questions are related. I'm undecided on this. I agree that having the installation instructions "right there" in the README is convenient, and commonly done for other tools, but it increases the probability of things getting out of sync. There are some workarounds, like including a specific snippet of text from the README into the docs, but they are hacky and will preclude us from using the fancy sphinx-design elements. Happy to go with whatever the majority of @neuroinformatics-unit/behaviour thinks... |
My view is:
|
In that case, I'm happy with @sfmig adding the "Quick install" section to the README, as described above. |
Sounds good! Will add it to this same PR if that's ok |
|
@niksirbi I had a go at removing the "table of contents" section, to have the quick install almost at the top and keep the README short - let me know what you think. |
Sounds good, I'm deep in atlas-land at the moment, so I'll review this tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!
Description
What is this PR
Why is this PR needed?
Installation link was returning 404
What does this PR do?
Fixes installation link and adds quick install instructions.
References
\
How has this PR been tested?
\
Is this a breaking change?
\
Does this PR require an update to the documentation?
\
Checklist: