Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation link and add quick install #185

Merged
merged 4 commits into from
May 23, 2024
Merged

Conversation

sfmig
Copy link
Contributor

@sfmig sfmig commented May 23, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Installation link was returning 404

What does this PR do?
Fixes installation link and adds quick install instructions.

References

\

How has this PR been tested?

\

Is this a breaking change?

\

Does this PR require an update to the documentation?

\

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

It was returning 404
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.68%. Comparing base (b2de775) to head (3f90072).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files          11       11           
  Lines         638      638           
=======================================
  Hits          636      636           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig
Copy link
Contributor Author

sfmig commented May 23, 2024

Questions/suggestions:

  • Should we have some automatic link checking for markdown files?

    • One option would be in CI (action repo here).
    • Another via pre-commit hooks (for example this, but there may be better ones). In a similar discussion before, wise people seemed to recommend against pre-commit because of expected flakiness.
  • Could we include the user installation code snippet in the README? I understand we don't want to have duplicated info to avoid having to edit it in too many places if it changes, but I wonder if in this case is worth the (small?) effort. It feels slightly faffy to redirect people to the docs for just the install command (I would keep the docs link tho in case they have issues or want further details). Maybe just:

    Quick install

    First create and activate a conda environment with the required dependencies:

     conda create -n movement-env -c conda-forge python=3.10 pytables
     conda activate movement-env
    

    Then install the movement package:

     pip install movement
    

    For further details, see the installation docs.

@sfmig sfmig marked this pull request as ready for review May 23, 2024 10:37
@sfmig sfmig requested review from niksirbi and a team and removed request for niksirbi May 23, 2024 10:40
@adamltyson
Copy link
Member

There's already link checking right via sphinx?

@sfmig
Copy link
Contributor Author

sfmig commented May 23, 2024

yeah, but I think atm it doesn't include the repo's README. Is that right @niksirbi?

@adamltyson
Copy link
Member

Oh yeah, sorry. That is correct (I think).

@niksirbi
Copy link
Member

I think the two questions are related.
If we keep the README minimal, as is now, I don't see much value in adding more automated checks specifically for it.
If we decide to add more stuff to the README, e.g. the installation instructions that Sofia suggests, additional checks would useful.

I'm undecided on this. I agree that having the installation instructions "right there" in the README is convenient, and commonly done for other tools, but it increases the probability of things getting out of sync. There are some workarounds, like including a specific snippet of text from the README into the docs, but they are hacky and will preclude us from using the fancy sphinx-design elements.

Happy to go with whatever the majority of @neuroinformatics-unit/behaviour thinks...

@adamltyson
Copy link
Member

My view is:

  • Have some additional minimal info in the readme (installation & quickstart)
  • Don't add any extra tooling to check it. I expect us to spend more time fixing the tooling rather than just checking the readme every so often.

@niksirbi
Copy link
Member

In that case, I'm happy with @sfmig adding the "Quick install" section to the README, as described above.

@sfmig
Copy link
Contributor Author

sfmig commented May 23, 2024

Sounds good! Will add it to this same PR if that's ok

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sfmig sfmig changed the title Fix installation link in readme Fix installation link and add quick install May 23, 2024
@sfmig
Copy link
Contributor Author

sfmig commented May 23, 2024

@niksirbi I had a go at removing the "table of contents" section, to have the quick install almost at the top and keep the README short - let me know what you think.

@niksirbi
Copy link
Member

Sounds good, I'm deep in atlas-land at the moment, so I'll review this tomorrow.

Copy link
Member

@niksirbi niksirbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@niksirbi niksirbi added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit 36fa102 May 23, 2024
17 checks passed
@lochhh lochhh deleted the smg/fix-link-readme branch May 24, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants