Give internal method a more descriptive name

neuroinformatics-unit · Feb 18, 2025 · 13526e2 · 13526e2
1 parent 2672938
commit 13526e2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/movement/roi/base.py b/movement/roi/base.py
@@ -171,7 +171,7 @@ def __str__(self) -> str:  # noqa: D105
             f"({n_points}{display_type})\n"
         ) + " -> ".join(f"({c[0]}, {c[1]})" for c in self.coords)
 
-    def _vector_from_keypoint_centroid(
+    def _vector_from_centroid_of_keypoints(
         self,
         data: xr.DataArray,
         position_keypoint: Hashable | Sequence[Hashable],
@@ -498,7 +498,7 @@ def compute_allocentric_angle(
             raise ValueError(f"Unknown angle convention: {angle_rotates}")
 
         # Determine the approach vector, for all time-points.
-        approach_vector = self._vector_from_keypoint_centroid(
+        approach_vector = self._vector_from_centroid_of_keypoints(
             data,
             position_keypoint=position_keypoint,
             boundary=boundary,
@@ -611,7 +611,7 @@ def compute_egocentric_angle(
             raise ValueError(f"Unknown angle convention: {angle_rotates}")
 
         # Determine the approach vector, for all time-points.
-        approach_vector = self._vector_from_keypoint_centroid(
+        approach_vector = self._vector_from_centroid_of_keypoints(
             data,
             position_keypoint=position_keypoint,
             boundary=boundary,

diff --git a/movement/roi/line.py b/movement/roi/line.py
@@ -159,7 +159,7 @@ def compute_angle_to_support_plane_of_segment(
         if position_keypoint is None:
             position_keypoint = [left_keypoint, right_keypoint]
 
-        normal = self._vector_from_keypoint_centroid(
+        normal = self._vector_from_centroid_of_keypoints(
             data,
             position_keypoint=position_keypoint,
             renamed_dimension="normal",