Refresh all filehandlers on named logger. #33
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resets the handlers on a named logger to empty so that repeated calls to
fancylog
respect the most recent calls arguments. This also adds a test to check the handlers are set as expected. Currently handlers are not removed from theroot
logger as I'm not sure if it would have unexpected consequences. It does mean that this kind of example below can happen:But I think generally people will call
fancylog.start_logging
only once so not much of a problem, but makes sense to set for named loggers. Maybe in the docs in future the recommended way to usefancylog
can be with a named logger as the behaviour is more predictable.