-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up framework for fetching data for testing #27
Conversation
d772d75
to
64a006e
Compare
64a006e
to
49fc060
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 1 1
Lines 5 5
=====================================
Misses 5 5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks goood @sfmig!
Very neatly organised. It works as far as I could tell. I used the annotations fixture to write some very simple tests, and it all worked as expected, incl. the re-download of files-registry.txt
each time the tests were run.
Co-authored-by: Niko Sirmpilatze <[email protected]>
Description
What is this PR
Why is this PR needed?
To support testing on sample data
What does this PR do?
References
\
How has this PR been tested?
Tests pass locally and in CI.
Is this a breaking change?
No.
Does this PR require an update to the documentation?
I opened a separate PR to add contributing guidelines following the
movement
example.The GIN repo includes a readme explaining how to add or edit test data.
Checklist: