Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up framework for fetching data for testing #27

Merged
merged 5 commits into from
Jan 23, 2025
Merged

Conversation

sfmig
Copy link
Contributor

@sfmig sfmig commented Jan 17, 2025

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
To support testing on sample data

What does this PR do?

  • Sets up the structure of tests and fixtures
  • Sets up a pooch registry to fetch test data from the corresponding GIN repo.
  • Adds a fixture for the "annotations" module that retrieves the data to test it.

References

\

How has this PR been tested?

Tests pass locally and in CI.

Is this a breaking change?

No.

Does this PR require an update to the documentation?

I opened a separate PR to add contributing guidelines following the movement example.

The GIN repo includes a readme explaining how to add or edit test data.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@sfmig sfmig changed the title Set up test data fetching Set up test data fetching (1) Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (bd43585) to head (fc1b0f2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #27   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines          5       5           
=====================================
  Misses         5       5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Jan 17, 2025
@sfmig sfmig changed the title Set up test data fetching (1) Set up framework for fetching data for testing Jan 20, 2025
@sfmig sfmig marked this pull request as ready for review January 20, 2025 11:44
@sfmig sfmig requested a review from niksirbi January 20, 2025 11:47
Copy link
Member

@niksirbi niksirbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks goood @sfmig!

Very neatly organised. It works as far as I could tell. I used the annotations fixture to write some very simple tests, and it all worked as expected, incl. the re-download of files-registry.txt each time the tests were run.

Co-authored-by: Niko Sirmpilatze <[email protected]>
@sfmig sfmig merged commit 0796ba5 into main Jan 23, 2025
11 checks passed
@sfmig sfmig deleted the smg/tests-setup branch January 23, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants