This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Benchmarking : Remote push job #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varun-sundar-rabindranath
requested review from
mgoin,
andy-neuma and
robertgshaw2-redhat
mgoin
reviewed
Mar 11, 2024
.github/workflows/remote-push.yml
Outdated
Comment on lines
31
to
34
| AWS-AVX2-192G-4-A10G-96G-Benchmark: | ||
| uses: ./.github/workflows/nm-benchmark.yml | ||
| with: | ||
| label: aws-avx2-192G-4-a10g-96G |
There was a problem hiding this comment.
maybe this could just a single GPU? it's just a 7b model so 4 GPUs seems like overkill
There was a problem hiding this comment.
Thanks guys.
4 GPU instance (Gi_per_thread = 4):
- build time : 10 mins
- bench time : 20 mins
1 GPU instance (Gi_per_thread = 12): - build time : 30 mins
- bench time : 20 mins
I am trying to see if it builds with Gi_per_thread = 8.
andy-neuma
approved these changes
Mar 11, 2024
.github/workflows/remote-push.yml
Outdated
Comment on lines
31
to
34
| AWS-AVX2-192G-4-A10G-96G-Benchmark: | ||
| uses: ./.github/workflows/nm-benchmark.yml | ||
| with: | ||
| label: aws-avx2-192G-4-a10g-96G |
varun-sundar-rabindranath
force-pushed
the
varun/remote-push-benchmark
branch
from
f83269e to
fbecddb
Compare
varun-sundar-rabindranath
force-pushed
the
varun/remote-push-benchmark
branch
from
997c64c to
960cb81
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Trigger minimal benchmarking on remote-push jobs.
TEST PLAN:
Jobs on this PR