Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Rs/sparse integration test clean 2 #67

Merged
merged 20 commits into from
Feb 28, 2024
Merged

Conversation

robertgshaw2-redhat
Copy link
Collaborator

@robertgshaw2-redhat robertgshaw2-redhat commented Feb 28, 2024

SUMMARY:
Adds support for end-to-end sparsity integration tests for 2:4 and unstructured using the logits comparison method

TEST PLAN:

  • Correctness testing by comparing "running dense" vs "running magic_wand" kernels
  • Memory usage by comparing the resulting size of the kv cache, and checking that the vllm cache is bigger (and thus the weights are smaller)

Copy link
Member

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when green. Could you fill out the PR summary as well before landing?

Copy link
Member

@andy-neuma andy-neuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked testmo run and the "test compressed" ran ... thanks!

@mgoin mgoin merged commit 0b80322 into main Feb 28, 2024
2 checks passed
@mgoin mgoin deleted the rs/sparse-integration-test-clean-2 branch February 28, 2024 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants