This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Skip some tests in Python < 3.10 #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbarbuzzi
requested review from
dhuangnm,
andy-neuma,
derekk-nm and
robertgshaw2-redhat
robertgshaw2-redhat
approved these changes
May 21, 2024
dbarbuzzi
changed the title
mosaicml/mpt-7b when using Python 3.8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR skips the
mosaicml/mpt-7bmodel in thetests/models/test_big_models.py::test_modelstest when using Python 3.8 since that model has custom code that does not work in Python 3.8.It also skips the clean shutdown test in Python < 3.10 as that was failing for some reason in our CI (running the file through pytest locally passes).