This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
forked from vllm-project/vllm
-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekk-nm
approved these changes
Apr 29, 2024
measured_value, | ||
) | ||
|
||
assert numpy.isclose(ground_truth, measured_value, rtol=0.05) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be nice to collect results for all of the metrics, and maybe all of the tasks, that are not close, then assert if there are any in error. that way all of the problems are reported, rather than having a developer fix one issue then getting an error on the next that they didn't fix yet.
dbarbuzzi
added a commit
that referenced
this pull request
May 1, 2024
This job will be reinstated shortly after with PR #210
This is in lieu of determining a more lenient yet still reasonable relative tolerance value.
andy-neuma
reviewed
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
The PR description has been rewritten for clarity based on current state.
The main goal of this PR is to update the actions added by @mgoin in #166 and translate one of them into an end-to-end test building off of the server framework from #200.
This also updates some of the actions and workflows to ensure they are running leanly and at appropriate times:
Pending
There are currently a few models that may occasionally fail the test which may relate to either non-determinism of marlin, implementation issues, or perhaps a combination:
neuralmagic/llama-2-7b-chat-marlin
has failed with anrtol
as high as0.2
neuralmagic/phi-2-super-marlin
has failed occasionally withrtol=0.05
Separately,
mistralai/Mixtral-8x7B-Instruct-v0.1
is untested due to the significant hardware required.