Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Abf149/fix semi structured sparse #16

Merged
merged 26 commits into from
Feb 16, 2024
Merged

Abf149/fix semi structured sparse #16

merged 26 commits into from
Feb 16, 2024

Conversation

afeldman-nm
Copy link

SUMMARY:

  • Fix bug whereby 2:4 is not being invoked
  • Eschew SparseTensor based implementation

TESTING:

  • examples/offline_inference_semi_structured_sparse.py

afeldman-nm and others added 26 commits February 1, 2024 23:41
@afeldman-nm
.gitignore magic_wand dir
b8810c7
@afeldman-nm
added 2:4 example (not actually using 2:4 yet\!)
d56b4c4
@afeldman-nm
use only cuda:0
1a8bc1c
@afeldman-nm
wip semi_structured_sparse_w16a16
2c6ff26
@afeldman-nm
restructuring sparsity
2856b91
@afeldman-nm
difficulty creating sparse parameter class
708fe1b
@afeldman-nm
first successful run with 2:4 sparse model; compat with magic_wand br…
40a8afb 
…anch safe_expose_semi_structured_sparse_tensor
@afeldman-nm
Merge branch 'main' into semi_structured
017a296
@afeldman-nm
woops uncommenting assert statement
a344b60
@afeldman-nm
fixes
7a2a7ed
@afeldman-nm
bfloat16
0711a74
@afeldman-nm
hopefully removed magic_wand submodule
fc85cac
@afeldman-nm
wip bench
d7b2f41
@LucasWilkinson
initial integration
ef64711
@LucasWilkinson
disable the semi-sparse stuff temporarily
202e655
@LucasWilkinson
Merge branch 'main' into lwilkinson/sparse-fused-gemm-integration
7f67d62
@LucasWilkinson
format fix
131a0a5
@LucasWilkinson
remove sparse benchmark
5c6a55e
@LucasWilkinson
small format fix
ae57f2c
@LucasWilkinson
remove useless comments
fb95394
@LucasWilkinson
cleanup spacing
b5ffb39
@LucasWilkinson
revert
9b69f56
@LucasWilkinson
missed pack
1fbc82f
@afeldman-nm
2:4 fix
c99f958
@afeldman-nm
merge
8f0416b
@afeldman-nm
lint/format
b80101a
mgoin
mgoin approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fair enough, thanks for the fix. i like the pad/extract! i know you have the example for usage but have you tried end-to-end benchmarking?

@mgoin mgoin merged commit 8599f81 into main Feb 16, 2024
2 checks passed
@mgoin mgoin deleted the abf149/fix-semi-structured-sparse branch February 16, 2024 14:28
robertgshaw2-redhat pushed a commit that referenced this pull request Feb 20, 2024
@afeldman-nm @LucasWilkinson @robertgshaw2-redhat
Abf149/fix semi structured sparse (#16)
39900cb 
SUMMARY:
- Fix bug whereby 2:4 is not being invoked
- Eschew SparseTensor based implementation

TESTING:
- examples/offline_inference_semi_structured_sparse.py

---------

Co-authored-by: Lucas Wilkinson <[email protected]>
robertgshaw2-redhat pushed a commit that referenced this pull request Feb 20, 2024
@afeldman-nm @LucasWilkinson @robertgshaw2-redhat
Abf149/fix semi structured sparse (#16)
6d80690 
SUMMARY:
- Fix bug whereby 2:4 is not being invoked
- Eschew SparseTensor based implementation

TESTING:
- examples/offline_inference_semi_structured_sparse.py

---------

Co-authored-by: Lucas Wilkinson <[email protected]>
robertgshaw2-redhat pushed a commit that referenced this pull request Feb 21, 2024
@afeldman-nm @LucasWilkinson @robertgshaw2-redhat
Abf149/fix semi structured sparse (#16)
7869191 
SUMMARY:
- Fix bug whereby 2:4 is not being invoked
- Eschew SparseTensor based implementation

TESTING:
- examples/offline_inference_semi_structured_sparse.py

---------

Co-authored-by: Lucas Wilkinson <[email protected]>
tlrmchlsmth pushed a commit that referenced this pull request Feb 21, 2024
@afeldman-nm @LucasWilkinson @tlrmchlsmth
Abf149/fix semi structured sparse (#16)
6143ab9 
SUMMARY:
- Fix bug whereby 2:4 is not being invoked
- Eschew SparseTensor based implementation

TESTING:
- examples/offline_inference_semi_structured_sparse.py

---------

Co-authored-by: Lucas Wilkinson <[email protected]>
robertgshaw2-redhat pushed a commit that referenced this pull request Feb 21, 2024
@afeldman-nm @LucasWilkinson @robertgshaw2-redhat
Abf149/fix semi structured sparse (#16)
c0ded57 
SUMMARY:
- Fix bug whereby 2:4 is not being invoked
- Eschew SparseTensor based implementation

TESTING:
- examples/offline_inference_semi_structured_sparse.py

---------

Co-authored-by: Lucas Wilkinson <[email protected]>
robertgshaw2-redhat pushed a commit that referenced this pull request Feb 22, 2024
@afeldman-nm @LucasWilkinson @robertgshaw2-redhat
Abf149/fix semi structured sparse (#16)
e11bb91 
SUMMARY:
- Fix bug whereby 2:4 is not being invoked
- Eschew SparseTensor based implementation

TESTING:
- examples/offline_inference_semi_structured_sparse.py

---------

Co-authored-by: Lucas Wilkinson <[email protected]>
robertgshaw2-redhat pushed a commit that referenced this pull request Feb 22, 2024
@afeldman-nm @LucasWilkinson @robertgshaw2-redhat
Abf149/fix semi structured sparse (#16)
7527b9c 
SUMMARY:
- Fix bug whereby 2:4 is not being invoked
- Eschew SparseTensor based implementation

TESTING:
- examples/offline_inference_semi_structured_sparse.py

---------

Co-authored-by: Lucas Wilkinson <[email protected]>
@andy-neuma andy-neuma mentioned this pull request Feb 23, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgoin mgoin mgoin approved these changes

@LucasWilkinson LucasWilkinson Awaiting requested review from LucasWilkinson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afeldman-nm @mgoin @LucasWilkinson