Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend tests are added #8

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

parfeniukink
Copy link
Contributor

@parfeniukink parfeniukink commented Jul 11, 2024

Summary

  • OpenAI backend service tests are added
  • .env.example is added as a source of a project configuration
  • README.md includes additional information about the OpenAI configuration

External service dependency

For the backend integration test, the compatible OpenAI API service is required.

@parfeniukink parfeniukink force-pushed the parfeniukink/tests-backfill/backend branch from fa97e20 to f956055 Compare July 11, 2024 13:05
@parfeniukink parfeniukink self-assigned this Jul 11, 2024
@parfeniukink parfeniukink marked this pull request as ready for review July 11, 2024 13:06
@parfeniukink parfeniukink force-pushed the parfeniukink/tests-backfill/backend branch 2 times, most recently from ac787ae to a0c2587 Compare July 11, 2024 14:04
* base unit tests are added
* OpenAI unit tests are added
* `Backend.submit` with OpenaAI backend integration test is added
* `.env.example` is added as a source of a project configuration
* `README.md` now has project configuring and testing small guide
@parfeniukink parfeniukink force-pushed the parfeniukink/tests-backfill/backend branch from a0c2587 to de2e4b4 Compare July 11, 2024 15:36
@parfeniukink
Copy link
Contributor Author

@markurtz removed project configuration changes from the PR

Copy link
Member

@markurtz markurtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parfeniukink parfeniukink merged commit ced437f into main Jul 12, 2024
@parfeniukink parfeniukink deleted the parfeniukink/tests-backfill/backend branch July 12, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants