Skip to content

Commit

Permalink
Add pre-commit checks to quality workflows (#25)
Browse files Browse the repository at this point in the history
## Summary

Enhances our CI/CD pipeline by introducing pre-commit checks to the
quality workflows. This ensures pre-check standards and requirements are
enforced even if developers do not install pre-commit locally and won't
break for others.

## Details

- Added a new job to the `.github/workflows/quality.yml` file that runs
pre-commit checks.
- This job runs on `ubuntu-latest` and is configured to set up Python
3.8, install pre-commit, and run the pre-commit checks on all files.
- Ensures that code quality checks must pass before merging, improving
code consistency and reducing errors.

## Test Plan

- Automated Testing: Verifying with this diff that the new github
actions will pass
  • Loading branch information
markurtz authored Aug 2, 2024
1 parent 331273c commit 996de81
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
13 changes: 13 additions & 0 deletions .github/workflows/quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,16 @@ jobs:
run: pip install tox
- name: Run type checks
run: tox -e types

precommit-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.8"
- name: Install pre-commit
run: pip install pre-commit
- name: Run pre-commit checks
run: pre-commit run --all-files
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ repos:
loguru,
numpy,
pydantic,
pydantic_settings,
pyyaml,
openai,
requests,
Expand Down

0 comments on commit 996de81

Please sign in to comment.