Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit Logging - Replace over putIfAbsent #2084

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Audit Logging - Replace over putIfAbsent #2084

merged 1 commit into from
Jan 23, 2024

Conversation

KalevGonvick
Copy link
Member

  • Changed HandlerUtil for updating audit info to replace instead of updating only if the key is absent when inserting data into AuditInfo.
  • Added trace statements to allow visibility into what data is being replaced
  • Updated MRAS and SalesForce Handlers to do the same as ExternalServiceHandler

@KalevGonvick
Changed logic to replace instead of putIfAbsent when updating audit i…
ad8732c 
…nfo. Added logging statements to easily trace updates to audit info.
@KalevGonvick KalevGonvick requested a review from stevehu January 23, 2024 18:23
@KalevGonvick KalevGonvick linked an issue Jan 23, 2024 that may be closed by this pull request
Fix ExternalServiceHandler Not Populating Endpoint Field With Correct Value #2079
Closed
@stevehu stevehu merged commit 873cdd8 into master Jan 23, 2024
@stevehu stevehu deleted the 2079-fix-externalservicehandler-not-populating-endpoint-field-with-correct-value branch January 23, 2024 18:26
stevehu pushed a commit that referenced this pull request Jan 25, 2024
@KalevGonvick
Changed logic to replace instead of putIfAbsent when updating audit i…
f141c2f 
…nfo. Added logging statements to easily trace updates to audit info. (#2084)
younggwon1 pushed a commit to younggwon1/light-4j that referenced this pull request Feb 10, 2024
@KalevGonvick
Changed logic to replace instead of putIfAbsent when updating audit i…
d89860b 
…nfo. Added logging statements to easily trace updates to audit info. (networknt#2084)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehu stevehu stevehu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix ExternalServiceHandler Not Populating Endpoint Field With Correct Value
2 participants
@KalevGonvick @stevehu