Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow cors handler to specify which method is allowed. #26

Closed
stevehu opened this issue Feb 16, 2017 · 1 comment
Closed

Allow cors handler to specify which method is allowed. #26

stevehu opened this issue Feb 16, 2017 · 1 comment
Assignees
@stevehu
Labels
enhancement Issue: Enhancement

Comments

@stevehu
Copy link
Contributor

stevehu commented Feb 16, 2017 •
edited
Loading

Currently, we control cors at host level without checking methods. Need to add another level of control at method level when host is allowed. The cors.json need to be changed.
@stevehu stevehu added the enhancement Issue: Enhancement label Feb 16, 2017
@stevehu stevehu self-assigned this Feb 17, 2017
@stevehu stevehu changed the title Allow cors handler to specify which method is allowed on certain host. Allow cors handler to specify which method is allowed. Feb 18, 2017
stevehu added a commit that referenced this issue Feb 18, 2017
@stevehu
fixes #26 add method access for cors
8aa2fdf
stevehu added a commit that referenced this issue Feb 18, 2017
@stevehu
fixes #26 add one statement in test for debugging
791b5e6
@stevehu
Copy link
Contributor Author

stevehu commented Feb 18, 2017

We can have method level control per host but it will make the configuration to messy and hard to maintain. In most of the use cases, people just want to control methods for all hosts.

@stevehu stevehu closed this as completed Feb 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevehu stevehu

Labels
enhancement Issue: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stevehu