Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed public interface of createFromFormat #34

Closed
wants to merge 1 commit into from
Closed

Fixed public interface of createFromFormat #34

wants to merge 1 commit into from

Conversation

stekycz
Copy link
Contributor

@stekycz stekycz commented Oct 9, 2014

Fixes #33

@dg
Copy link
Member

dg commented Oct 9, 2014

To return FALSE is really not good idea. What about any exception?

@fprochazka
Copy link
Contributor

@dg that would break the original api

@dg dg closed this in 9959025 Oct 26, 2014
dg pushed a commit that referenced this pull request Oct 26, 2014
@stekycz @dg
DateTime: createFromFormat returns FALSE on failure [Closes #33][Closes
09161a4 
#34]
milo pushed a commit to milo/nette-utils that referenced this pull request Feb 25, 2021
@fprochazka
Merge pull request nette#34 from TheDocX/patch-1
6a65e7f 
Update getting-started.texy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong returned value from createFromFormat
3 participants
@stekycz @dg @fprochazka