Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderer - easier extensibility #299

Merged
merged 1 commit into from
Mar 8, 2023
Merged

renderer - easier extensibility #299

merged 1 commit into from
Mar 8, 2023

Conversation

bartko-s
Copy link
Contributor

@bartko-s bartko-s commented Mar 1, 2023

  • Easier extensibility
  • BC break? no

Riesil som problem kde som potreboval upravit renderovanie checkboxu.

Nette Checkbox::getControl renderuje tuto struktutu

<div>
    <label>
        <checkbox />
    </label>
</div

Ja som ale potreboval toto

<div>
    <label />
    <checkbox />
</div>

Toto sa da dosiahnut len ak si extendnem \Nette\Forms\Rendering\DefaultFormRenderer a vnom extendnem

  • \Nette\Forms\Rendering\DefaultFormRenderer::renderControl
  • \Nette\Forms\Rendering\DefaultFormRenderer::renderPairMulti
  • \Nette\Forms\Rendering\DefaultFormRenderer::doRenderErrors

Vo funkciach renderControl a renderPairMulti kde je riadok $el = $control->getControl(); sa robi to kuzlo ktore potrebujem. Tento pull request jednoducho tuto cast kodu vytiahne do funkcie ktoru je jednoduche extendnut a moj problem by bol jednoducho vyrieseny bez kopirovanie velkej casti renderera.

@dg dg force-pushed the master branch 5 times, most recently from a1994d2 to 6e46277 Compare March 8, 2023 22:38
@dg dg changed the base branch from master to v3.1 March 8, 2023 22:41
@dg dg changed the base branch from v3.1 to master March 8, 2023 22:41
@dg dg force-pushed the master branch 2 times, most recently from a1994d2 to 7f895f6 Compare March 8, 2023 22:43
@dg
Copy link
Member

dg commented Mar 8, 2023

Good idea.

@dg dg merged commit 2e6e101 into nette:master Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants