Validator::validatePattern(): fix value object support (fixes #205) #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xificurk
force-pushed
the
fix-pattern-validator
branch
from
f3e84e6 to
b280a42
Compare
… for mapping to objects
Bootstrap 4 marks invalid controls with is-invalid class. Let’s allow to set this class in DefaultFormRenderer.
xificurk
force-pushed
the
fix-pattern-validator
branch
from
b280a42 to
8b2c7dd
Compare
xificurk
force-pushed
the
fix-pattern-validator
branch
from
8b2c7dd to
4fb6712
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
2df07d6 to
82e9980
Compare
|
Merged |
|
@dg Thanks, would you please backport it to 2.4.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #205 for details. The PR targets master, but should be backported to 2.4 branch as well, because the change that introduced this issue (#192) was already backported.