Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1580: update frontend config for CLI #819

Merged
merged 1 commit into from
Dec 12, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions controllers/consoleplugin/config/static-frontend-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,7 @@ columns:
- id: Bytes
name: Bytes
tooltip: The total aggregated number of bytes.
field: Bytes
fields:
- Bytes
- PktDropBytes
Expand All @@ -448,6 +449,7 @@ columns:
- id: Packets
name: Packets
tooltip: The total aggregated number of packets.
field: Packets
fields:
- Packets
- PktDropPackets
Expand All @@ -473,6 +475,41 @@ columns:
calculated: substract(column.CollectionTime,TimeFlowEndMs)
default: false
width: 5
- id: PktDropBytes
Copy link
Member

@jotak jotak Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it going to have side effect on the console plugin, to have this new field (since it's also nested under Bytes) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an impact on both table and side panel indeed:

  • table allow the user to pick these fields (disabled by default)
  • side panel display these fields separately wich need a small refactor to skip these as it's already included in the other ones

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name: Dropped Bytes
tooltip: The total aggregated number of bytes dropped.
field: PktDropBytes
default: false
width: 5
feature: pktDrop
- id: PktDropPackets
name: Dropped Packets
tooltip: The total aggregated number of packets dropped.
field: PktDropPackets
default: false
width: 5
feature: pktDrop
- id: PktDropLatestState
name: Drop State
tooltip: TCP state on last dropped packet.
field: PktDropLatestState
default: false
width: 10
feature: pktDrop
- id: PktDropLatestDropCause
name: Drop Cause
tooltip: TCP state on last dropped packet.
field: PktDropLatestDropCause
default: false
width: 10
feature: pktDrop
- id: PktDropLatestFlags
name: Drop Flags
tooltip: TCP flags on last dropped packet.
field: PktDropLatestFlags
default: false
width: 10
feature: pktDrop
Comment on lines +478 to +512
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msherif1234 FYI you asked for this earlier 👼

- id: DNSId
group: DNS
name: DNS Id
Expand Down
Loading