Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1737 consolePlugin fails to get deployed on 4.17 cluster #718

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

jpinsonneau
Copy link
Contributor

Description

Update console plugin API to work on OCP 4.17+

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@jpinsonneau jpinsonneau requested a review from msherif1234 July 22, 2024 16:22
@msherif1234
Copy link
Contributor

msherif1234 commented Jul 22, 2024

how about calling the pkt consoleapilatest and u can change v1alpha1 to v1 and if it changed again to v2 or something u will change in one place ?

@jpinsonneau
Copy link
Contributor Author

how about calling the pkt consoleapilatest and u can change v1alpha1 to v1 and if it changed again to v2 or something u will change in one place ?

yeah that's something we could do. But we should do that on all APIs not only the console one

@jotak
Copy link
Member

jotak commented Jul 23, 2024

thanks @jpinsonneau !
/lgtm

For 4.12 cluster or before (which are unsupported), people will have to explicitly turn off the plugin deployment. They can still use the test console btw, if I'm correct.

@memodi
Copy link
Contributor

memodi commented Jul 23, 2024

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 23, 2024
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:bf1e4dd
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-bf1e4dd
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-bf1e4dd

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:bf1e4dd make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-bf1e4dd

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-bf1e4dd
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@memodi
Copy link
Contributor

memodi commented Jul 23, 2024

For 4.12 cluster or before (which are unsupported), people will have to explicitly turn off the plugin deployment. They can still use the test console btw, if I'm correct.

even though 4.12 support has ended, it has extended support running through Jan 17 2025. I am not sure what's the recourse if someone running on 4.12 until then and upgrades to 1.7?

@jotak
Copy link
Member

jotak commented Jul 24, 2024

@memodi in midstream I removed 4.12 support for 1.7, meaning that the operator should not be available for upgrade on these clusters. That was also needed for FIPS. I think (hope) this plan can work - and in case of critical bugs we can still release a 1.6.2 for people running on 4.12

@memodi
Copy link
Contributor

memodi commented Jul 24, 2024

@memodi in midstream I removed 4.12 support for 1.7, meaning that the operator should not be available for upgrade on these clusters. That was also needed for FIPS. I think (hope) this plan can work - and in case of critical bugs we can still release a 1.6.2 for people running on 4.12

SGTM.

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Jul 24, 2024
Copy link

openshift-ci bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau
Copy link
Contributor Author

Thanks everyone ! Merging now

@openshift-merge-bot openshift-merge-bot bot merged commit bbcc16d into main Jul 24, 2024
11 checks passed
jotak pushed a commit to jotak/network-observability-operator that referenced this pull request Sep 9, 2024
…etobserv#718)

* openshift api vendor

* update console plugin api

* restore envtest openshift manifests
openshift-merge-bot bot pushed a commit that referenced this pull request Sep 10, 2024
…Backport 1.6] (#762)

* NETOBSERV-1737 consolePlugin fails to get deployed on 4.17 cluster (#718)

* openshift api vendor

* update console plugin api

* restore envtest openshift manifests

* update bundle

* NETOBSERV-1707: move to go 1.22 (#682)

---------

Co-authored-by: Julien Pinsonneau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants