-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1737 consolePlugin fails to get deployed on 4.17 cluster #718
Conversation
how about calling the pkt |
yeah that's something we could do. But we should do that on all APIs not only the console one |
thanks @jpinsonneau ! For 4.12 cluster or before (which are unsupported), people will have to explicitly turn off the plugin deployment. They can still use the test console btw, if I'm correct. |
/ok-to-test |
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:bf1e4dd make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-bf1e4dd Or as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-bf1e4dd
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
even though 4.12 support has ended, it has extended support running through Jan 17 2025. I am not sure what's the recourse if someone running on 4.12 until then and upgrades to 1.7? |
@memodi in midstream I removed 4.12 support for 1.7, meaning that the operator should not be available for upgrade on these clusters. That was also needed for FIPS. I think (hope) this plan can work - and in case of critical bugs we can still release a 1.6.2 for people running on 4.12 |
SGTM. /label qe-approved |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks everyone ! Merging now |
…etobserv#718) * openshift api vendor * update console plugin api * restore envtest openshift manifests
…Backport 1.6] (#762) * NETOBSERV-1737 consolePlugin fails to get deployed on 4.17 cluster (#718) * openshift api vendor * update console plugin api * restore envtest openshift manifests * update bundle * NETOBSERV-1707: move to go 1.22 (#682) --------- Co-authored-by: Julien Pinsonneau <[email protected]>
Description
Update console plugin API to work on OCP 4.17+
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.