Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable openshift subnets by default #619

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Enable openshift subnets by default #619

merged 2 commits into from
Apr 16, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Apr 16, 2024

Enabling openshift subnets by default allows to accurately identify cluster external traffic, which is a major use case for netobserv

Also add more info to CRD doc

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@jotak
Enable openshift subnets by default
c487181 
Enabling openshift subnets by default allows to accurately identify
cluster external traffic, which is a major use case for netobserv
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak requested review from memodi and jpinsonneau April 16, 2024 08:43
OlivierCazade
OlivierCazade approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Apr 16, 2024
@openshift-ci openshift-ci bot removed the lgtm label Apr 16, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 16, 2024

New changes are detected. LGTM label has been removed.

msherif1234
msherif1234 reviewed Apr 16, 2024
View reviewed changes
apis/flowcollector/v1beta1/flowcollector_types.go
@@ -910,7 +911,8 @@ type DebugConfig struct {
// `SubnetLabels` allows to define custom labels on subnets and IPs or to enable automatic labelling of recognized subnets in OpenShift.
type SubnetLabels struct {
// `openShiftAutoDetect` allows, when set to `true`, to detect automatically the machines, pods and services subnets based on the
// OpenShift install configuration and the Cluster Network Operator configuration.
// OpenShift install configuration and the Cluster Network Operator configuration. Indirectly, this is a way to accurately detect
// external traffic: flows that are not labeled for those subnets are external to the cluster. Enabled by default on OpenShift.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do u want to add
//+kubebuilder:default:=true

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to keep nil by default , and have default handling in code, it's more flexible and allows us to change the default values between releases

msherif1234
msherif1234 reviewed Apr 16, 2024
View reviewed changes
apis/flowcollector/v1beta2/flowcollector_types.go
@@ -1121,7 +1122,8 @@ type AdvancedPluginConfig struct {
// `SubnetLabels` allows to define custom labels on subnets and IPs or to enable automatic labelling of recognized subnets in OpenShift.
type SubnetLabels struct {
// `openShiftAutoDetect` allows, when set to `true`, to detect automatically the machines, pods and services subnets based on the
// OpenShift install configuration and the Cluster Network Operator configuration.
// OpenShift install configuration and the Cluster Network Operator configuration. Indirectly, this is a way to accurately detect
// external traffic: flows that are not labeled for those subnets are external to the cluster. Enabled by default on OpenShift.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too ?

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 16, 2024

@jotak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-operator 7e24e55 link false /test e2e-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Apr 16, 2024
@jotak jotak merged commit 10a6846 into netobserv:main Apr 16, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msherif1234 msherif1234 msherif1234 left review comments

@OlivierCazade OlivierCazade OlivierCazade approved these changes

@memodi memodi Awaiting requested review from memodi

@jpinsonneau jpinsonneau Awaiting requested review from jpinsonneau

Assignees

@OlivierCazade OlivierCazade

Labels
no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jotak @msherif1234 @OlivierCazade