-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image references file #553
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-operator |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #553 +/- ##
==========================================
+ Coverage 57.79% 57.87% +0.08%
==========================================
Files 72 73 +1
Lines 9532 9543 +11
==========================================
+ Hits 5509 5523 +14
+ Misses 3686 3684 -2
+ Partials 337 336 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It seems common to put this file under the https://github.com/openshift/cluster-monitoring-operator/blob/master/manifests/image-references |
/lgtm |
Description
NETOBSERV-1467 - it appears we need this file to pass operand images to be able to build pre-merge images
See this WIP PR: openshift/release#48224, the e2e-test failed with error when trying to have flowlogs-pipeline as input.
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.