-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1203: minor adjustments [backport 1.5] #547
Conversation
- Add "AddZone" field also in v1beta1 - Update descriptions / avoid using "will" - Use helper functions (centralizes handling of default/nil case)
@jotak: This pull request references NETOBSERV-1203 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-1.5 #547 +/- ##
===============================================
- Coverage 57.93% 57.87% -0.06%
===============================================
Files 72 72
Lines 9524 9532 +8
===============================================
- Hits 5518 5517 -1
- Misses 3673 3680 +7
- Partials 333 335 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Backport of #545
Description
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.