Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1203: minor adjustments [backport 1.5] #547

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Jan 29, 2024

Backport of #545

  • Add "AddZone" field also in v1beta1
  • Update descriptions / avoid using "will"
  • Use helper functions (centralizes handling of default/nil case)

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

- Add "AddZone" field also in v1beta1
- Update descriptions / avoid using "will"
- Use helper functions (centralizes handling of default/nil case)
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 29, 2024

@jotak: This pull request references NETOBSERV-1203 which is a valid jira issue.

In response to this:

Backport of #545

  • Add "AddZone" field also in v1beta1
  • Update descriptions / avoid using "will"
  • Use helper functions (centralizes handling of default/nil case)

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (a01f2d9) 57.93% compared to head (768b562) 57.87%.

Files Patch % Lines
...pis/flowcollector/v1beta1/zz_generated.deepcopy.go 0.00% 5 Missing ⚠️
controllers/ebpf/agent_controller.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.5     #547      +/-   ##
===============================================
- Coverage        57.93%   57.87%   -0.06%     
===============================================
  Files               72       72              
  Lines             9524     9532       +8     
===============================================
- Hits              5518     5517       -1     
- Misses            3673     3680       +7     
- Partials           333      335       +2     
Flag Coverage Δ
unittests 57.87% <68.42%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotak
Copy link
Member Author

jotak commented Jan 30, 2024

/approve

Copy link

openshift-ci bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak merged commit 6375cf3 into netobserv:release-1.5 Jan 30, 2024
15 of 16 checks passed
@jotak jotak deleted the zone-adjustment-1.5 branch February 8, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants