Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETOBSERV-1383: do not turn off conversion-gen #480

Merged
merged 1 commit into from
Nov 2, 2023
Merged

NETOBSERV-1383: do not turn off conversion-gen #480

merged 1 commit into from
Nov 2, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Oct 31, 2023

conversion-gen was turned off on some fields because it didn't work well with some alpha1 missing fields.

But the problem is that it's also turned off for beta1<->beta2 conversions, which we don't want.

This is turning them back on, however, adding the missing fields in alpha1 (which is deprecated) so that it converts without trouble

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@jotak
NETOBSERV-1383 do not turn off conversion-gen
048a9c5 
conversion-gen was turned off on some fields because it didn't work well
with some alpha1 missing fields.

But the problem is that it's also turned off for beta1<->beta2
conversions, which we don't want.

This is turning them back on, however, adding the missing fields in
alpha1 (which is deprecated) so that it converts without trouble
@jotak jotak requested review from msherif1234 and Amoghrd October 31, 2023 13:56
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 31, 2023 •
edited by openshift-ci bot
Loading

@jotak: This pull request references NETOBSERV-1383 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

conversion-gen was turned off on some fields because it didn't work well with some alpha1 missing fields.

But the problem is that it's also turned off for beta1<->beta2 conversions, which we don't want.

This is turning them back on, however, adding the missing fields in alpha1 (which is deprecated) so that it converts without trouble

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov Codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (1c0449c) 55.00% compared to head (048a9c5) 55.13%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
+ Coverage   55.00%   55.13%   +0.13%     
==========================================
  Files          47       47              
  Lines        6460     6468       +8     
==========================================
+ Hits         3553     3566      +13     
+ Misses       2666     2665       -1     
+ Partials      241      237       -4
Flag Coverage Δ
unittests 55.13% <0.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/v1beta1/flowcollector_types.go 100.00% <ø> (ø)
api/v1beta2/flowcollector_types.go 100.00% <ø> (ø)
api/v1beta1/zz_generated.conversion.go 0.23% <0.00%> (-0.01%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Amoghrd
Copy link
Contributor

Amoghrd commented Oct 31, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 31, 2023
@github-actions GitHub Actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:1965500
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-1965500
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-1965500

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:1965500 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-1965500

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-1965500
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@Amoghrd
Copy link
Contributor

Amoghrd commented Nov 1, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Nov 1, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 1, 2023 •
edited by openshift-ci bot
Loading

@jotak: This pull request references NETOBSERV-1383 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

conversion-gen was turned off on some fields because it didn't work well with some alpha1 missing fields.

But the problem is that it's also turned off for beta1<->beta2 conversions, which we don't want.

This is turning them back on, however, adding the missing fields in alpha1 (which is deprecated) so that it converts without trouble

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msherif1234
Copy link
Contributor

/lgtm
its expected the older version won't match new version so at somepoint we probably need to findout what is the best practice to do this instead of adding new fields to older version but not urgent

@openshift-ci openshift-ci bot added the lgtm label Nov 1, 2023
@Amoghrd
Copy link
Contributor

Amoghrd commented Nov 1, 2023

/approve

1 similar comment
@jotak
Copy link
Member Author

jotak commented Nov 2, 2023

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amoghrd, jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 2, 2023
@openshift-ci openshift-ci bot merged commit fc1c80c into netobserv:main Nov 2, 2023
@jotak jotak deleted the conversion-gen-on branch November 7, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msherif1234 msherif1234 Awaiting requested review from msherif1234

@Amoghrd Amoghrd Awaiting requested review from Amoghrd

Assignees

@msherif1234 msherif1234

Labels
approved jira/valid-reference lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jotak @openshift-ci-robot @Amoghrd @msherif1234