-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1340: Add operator to "Networking" category in OperatorHub #451
NETOBSERV-1340: Add operator to "Networking" category in OperatorHub #451
Conversation
@stleerh: This pull request references NETOBSERV-1340 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "netobserv-1.5" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
=======================================
Coverage 54.92% 54.92%
=======================================
Files 47 47
Lines 6382 6382
=======================================
Hits 3505 3505
Misses 2635 2635
Partials 242 242
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/lgtm |
@stleerh : I had to revert your previous PR adding to Observability category, as this isn't a recognized category. Adding to "Networking" is fine I guess, since this category already exists; you'll need to rebase the PR to fix conflict though |
(I resolved the conflict via github) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…etobserv#451) Co-authored-by: Joel Takvorian <[email protected]>
There is a request to also add Network Observability to the "Networking" category.
See #440 for related details.