NETOBSERV-1231 RTT metrics

[jpinsonneau]

Description

• adds RTT metrics to FLP metrics definitions

As RTT is dev preview for 1.4, we don't need to document and test this unless it's merged after 1.4 release.
It can be backported if needed.

Dependencies

Rely on #394. Merge first !
Requires netobserv/flowlogs-pipeline#478 to skip flows that doesn't contains TimeFlowRttNs field

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Patch coverage: 17.39% and project coverage change: -0.41% ⚠️

Comparison is base (623a3b2) 55.70% compared to head (cae4e36) 55.29%.

❗ Current head cae4e36 differs from pull request most recent head 53ea2d8. Consider uploading reports for the commit 53ea2d8 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
- Coverage   55.70%   55.29%   -0.41%     
==========================================
  Files          46       45       -1     
  Lines        5960     5888      -72     
==========================================
- Hits         3320     3256      -64     
+ Misses       2410     2406       -4     
+ Partials      230      226       -4     

Flag	Coverage Δ
unittests	55.29% <17.39%> (-0.41%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
api/v1alpha1/flowcollector_webhook.go	0.00% <0.00%> (ø)
api/v1alpha1/zz_generated.conversion.go	0.25% <ø> (ø)
api/v1beta1/flowcollector_types.go	100.00% <ø> (ø)
api/v1beta1/zz_generated.deepcopy.go	53.79% <0.00%> (+0.69%)	⬆️
controllers/consoleplugin/consoleplugin_objects.go	94.61% <0.00%> (ø)
controllers/ebpf/agent_controller.go	69.59% <0.00%> (-3.57%)	⬇️
...ntrollers/ebpf/internal/permissions/permissions.go	45.50% <0.00%> (-0.56%)	⬇️
controllers/flowlogspipeline/flp_common_objects.go	80.88% <0.00%> (+0.19%)	⬆️
pkg/helper/flowcollector.go	65.97% <57.14%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Amoghrd]

/ok-to-test

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:b6455e9
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-b6455e9
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-b6455e9

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:b6455e9 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-b6455e9

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-b6455e9
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[jpinsonneau]

Holding this as it will need to be reworked with NETOBSERV-1284 approach