Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1005 dashboard: use sum...by [1.3 backport] #358

Merged

Conversation

jotak
Copy link
Member

@jotak jotak commented Jun 1, 2023

  • Fix metrics aggregations by using sum...by
  • Do not split by FLP pod reporter as it's an implementation detail

Ref PR: #356

- Fix metrics aggregations by using sum...by
- Do not split by FLP pod reporter as it's an implementation detail
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #358 (c18c984) into release-1.3 (ca61fad) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-1.3     #358   +/-   ##
============================================
  Coverage        53.37%   53.37%           
============================================
  Files               45       45           
  Lines             5328     5328           
============================================
  Hits              2844     2844           
  Misses            2281     2281           
  Partials           203      203           
Flag Coverage Δ
unittests 53.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

jpinsonneau
jpinsonneau previously approved these changes Jun 2, 2023
@openshift-ci openshift-ci bot added the lgtm label Jun 2, 2023
@jotak jotak changed the title NETOBSERV-1005 dashboard: use sum...by NETOBSERV-1005 dashboard: use sum...by [1.3 backport] Jun 2, 2023
@memodi
Copy link
Contributor

memodi commented Jun 2, 2023

/lgtm
/label qe-approved
tested PR #356

@openshift-ci openshift-ci bot added qe-approved QE has approved this pull request lgtm labels Jun 2, 2023
@jotak
Copy link
Member Author

jotak commented Jun 2, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 2, 2023
@openshift-merge-robot openshift-merge-robot merged commit a219987 into netobserv:release-1.3 Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants